breadcrumbs.vars.php is missing code from the D7 branch. This patch re-adds it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neardark’s picture

Status: Active » Needs review
FileSize
1.1 KB
neardark’s picture

Status: Needs review » Fixed
neardark’s picture

Status: Fixed » Needs review
FileSize
1.36 KB

Actually, looks like menu_get_item has been removed. Here's the reworked ticket. Can you review when you have time -- sorry about missing this.

neardark’s picture

Assigned: neardark » markhalliwell
markhalliwell’s picture

Status: Needs review » Needs work

Ah, yeah, this looks more D8-ish :)

  1. +++ b/templates/system/breadcrumb.vars.php
    @@ -17,15 +17,13 @@ function bootstrap_preprocess_breadcrumb(&$variables) {
    -        'class' => array('active'),
    

    If possible, we still need this class, did the breadcrumbs array item structure change as well?

  2. +++ b/templates/system/breadcrumb.vars.php
    @@ -17,15 +17,13 @@ function bootstrap_preprocess_breadcrumb(&$variables) {
    +      $variables['breadcrumb'] = $breadcrumb;
    

    This isn't needed, $breadcrumb is referenced from above in the code.

neardark’s picture

Assigned: markhalliwell » neardark
neardark’s picture

Assigned: neardark » markhalliwell
Status: Needs work » Needs review
FileSize
1.64 KB

Ahhh, thanks. Added back in active class.

Status: Needs review » Needs work

The last submitted patch, 7: re_add_bootstrap-2408041-7.patch, failed testing.

neardark’s picture

Status: Needs work » Needs review
FileSize
1.97 KB

Bah.

markhalliwell’s picture

Assigned: markhalliwell » Unassigned
Status: Needs review » Reviewed & tested by the community

Code looks good to me. I'll mark as RTBC if you think it's good to go too.

  • neardark committed c19768d on 8.x-3.x
    Issue #2408041 by neardark: Re-add bootstrap breadcrumb title work to D8...
neardark’s picture

Status: Reviewed & tested by the community » Fixed

Committed. BTW, I'll try and get more organized with dealing with DO's issue queue as well as keeping the two branches as close to parity as possible. J

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.