Problem/Motivation

Same as #2136559: Config entity admin lists show configuration with overrides (eg. localized) but for config translation admin lists such as admin/config/regional/config-translation/configurable_language.

Proposed resolution

Load entities without overrides.

Remaining tasks

Do it. Review. Commit.

User interface changes

Configuration translation admin lists will not show localized / overridden configuration.

API changes

None.

Files: 
CommentFileSizeAuthor
#8 2407907-configuration-translation-entity-listings-displays-items-overriden-07.patch2.32 KBYesCT
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,108 pass(es). View
#8 2407907-configuration-translation-entity-listings-displays-items-overriden-07-testonly.patch1.33 KBYesCT
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,115 pass(es), 2 fail(s), and 0 exception(s). View
#8 interdiff.02.07.txt708 bytesYesCT
#7 2407907-configuration-translation-entity-listings-displays-items-overriden-07.patch2.32 KBmr.york
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,097 pass(es). View
#2 2407907-configuration-translation-entity-listings-displays-items-overriden-02.patch2.36 KBmr.york
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,006 pass(es). View

Comments

mr.york’s picture

Assigned: Unassigned » mr.york
Issue tags: +SprintWeekend2015
mr.york’s picture

Status: Active » Needs review
FileSize
2.36 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,006 pass(es). View

Attached the patch.

Gábor Hojtsy’s picture

Looking forward to test results :) Patch looks good on visual review.

+++ b/core/modules/config_translation/src/Controller/ConfigTranslationEntityListBuilder.php
@@ -8,12 +8,12 @@
-class ConfigTranslationEntityListBuilder extends EntityListBuilder implements ConfigTranslationEntityListBuilderInterface {
+class ConfigTranslationEntityListBuilder extends ConfigEntityListBuilder implements ConfigTranslationEntityListBuilderInterface {

Good thinking!

Gábor Hojtsy’s picture

Status: Needs review » Needs work

Tests passed nicely. Wanted to RTBC but then found this:

+++ b/core/modules/config_translation/src/Tests/ConfigTranslationOverviewTest.php
@@ -120,4 +120,28 @@ public function testHiddenEntities() {
+    $edited_label = 'Edited label';

You don't use this anywhere.

develCuy’s picture

Issue tags: -SprintWeekend2015Queue
develCuy’s picture

Issue tags: +SprintWeekend2015Queue

Removed SprintWeekend2015Queue by mistake.

mr.york’s picture

Status: Needs work » Needs review
FileSize
2.32 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,097 pass(es). View

Remove $edited_label variable in the test.

YesCT’s picture

FileSize
708 bytes
1.33 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,115 pass(es), 2 fail(s), and 0 exception(s). View
2.32 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,108 pass(es). View

looks good. just that unused var was removed.

made an interdiff.
For instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff

will upload a tests only patch
See https://drupal.org/contributor-tasks/write-tests

(and a patch which is just the same 07, which is the one to commit)

keeping at needs review just to trigger the bot.

Kristen Pol’s picture

Status: Needs review » Reviewed & tested by the community

This is RTBC per #4 since patch #8 addressed Gábor's one issue (removing unused code) and the patch is green.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 02ce89c and pushed to 8.0.x. Thanks!

  • alexpott committed 02ce89c on 8.0.x
    Issue #2407907 by YesCT, mr.york: Configuration translation entity...
Gábor Hojtsy’s picture

Issue tags: -sprint

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.