Problem/Motivation

Same as #2136559: Config entity admin lists show configuration with overrides (eg. localized) but for config translation admin lists such as admin/config/regional/config-translation/configurable_language.

Proposed resolution

Load entities without overrides.

Remaining tasks

Do it. Review. Commit.

User interface changes

Configuration translation admin lists will not show localized / overridden configuration.

API changes

None.

CommentFileSizeAuthor
#8 2407907-configuration-translation-entity-listings-displays-items-overriden-07.patch2.32 KBYesCT
#8 2407907-configuration-translation-entity-listings-displays-items-overriden-07-testonly.patch1.33 KBYesCT
#8 interdiff.02.07.txt708 bytesYesCT
#7 2407907-configuration-translation-entity-listings-displays-items-overriden-07.patch2.32 KBmr.york
#2 2407907-configuration-translation-entity-listings-displays-items-overriden-02.patch2.36 KBmr.york
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mr.york’s picture

mr.york CreditAttribution: mr.york commented
Assigned: Unassigned » mr.york
Issue tags: +SprintWeekend2015
mr.york’s picture

mr.york CreditAttribution: mr.york commented
Status: Active » Needs review
FileSize
2407907-configuration-translation-entity-listings-displays-items-overriden-02.patch2.36 KB

Attached the patch.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Looking forward to test results :) Patch looks good on visual review.

+++ b/core/modules/config_translation/src/Controller/ConfigTranslationEntityListBuilder.php
@@ -8,12 +8,12 @@
-class ConfigTranslationEntityListBuilder extends EntityListBuilder implements ConfigTranslationEntityListBuilderInterface {
+class ConfigTranslationEntityListBuilder extends ConfigEntityListBuilder implements ConfigTranslationEntityListBuilderInterface {

Good thinking!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Needs work

Tests passed nicely. Wanted to RTBC but then found this:

+++ b/core/modules/config_translation/src/Tests/ConfigTranslationOverviewTest.php
@@ -120,4 +120,28 @@ public function testHiddenEntities() {
+    $edited_label = 'Edited label';

You don't use this anywhere.

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented
Issue tags: -SprintWeekend2015Queue
DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented
Issue tags: +SprintWeekend2015Queue

Removed SprintWeekend2015Queue by mistake.

mr.york’s picture

mr.york CreditAttribution: mr.york commented
Status: Needs work » Needs review
FileSize
2407907-configuration-translation-entity-listings-displays-items-overriden-07.patch2.32 KB

Remove $edited_label variable in the test.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
interdiff.02.07.txt708 bytes
2407907-configuration-translation-entity-listings-displays-items-overriden-07-testonly.patch1.33 KB
2407907-configuration-translation-entity-listings-displays-items-overriden-07.patch2.32 KB

looks good. just that unused var was removed.

made an interdiff.
For instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff

will upload a tests only patch
See https://drupal.org/contributor-tasks/write-tests

(and a patch which is just the same 07, which is the one to commit)

keeping at needs review just to trigger the bot.

The last submitted patch, 8: 2407907-configuration-translation-entity-listings-displays-items-overriden-07-testonly.patch, failed testing.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol commented
Status: Needs review » Reviewed & tested by the community

This is RTBC per #4 since patch #8 addressed Gábor's one issue (removing unused code) and the patch is green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 02ce89c and pushed to 8.0.x. Thanks!

  • alexpott committed 02ce89c on 8.0.x 
    Issue #2407907 by YesCT, mr.york: Configuration translation entity...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Issue tags: -sprint

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.