Twig Templates to Copy

  • core/modules/system/templates/admin-block-content.html.twig
  • core/modules/system/templates/admin-block.html.twig
  • core/modules/system/templates/admin-page.html.twig
#3 interdiff.txt3.1 KBcrowdcg
#3 2407713-3.patch1.78 KBcrowdcg
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,092 pass(es). View
#2 issue-2407713-2.patch4.8 KBSivaji
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,949 pass(es). View


Sivaji’s picture

Sivaji’s picture

Status: Active » Needs review
4.8 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,949 pass(es). View
crowdcg’s picture

1.78 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,092 pass(es). View
3.1 KB

Removed the "set classes" in core/modules/system/templates/admin-block-content.html.twig

davidhernandez’s picture

Status: Needs review » Postponed

Postponing this until we decide how we are moving forward. Keep an eye on #2348543: [meta] Consensus Banana Phase 2, transition templates to the Classy theme for updates. Thanks.

mortendk’s picture

still postponed ? ;)

mortendk’s picture

Issue tags: +classy
mortendk’s picture

None of these templates we copied over to classy on the big merge, so we need to take a desission if we want to move em over.
Mistakenly made an duplicated issue on this with this summary that i think summons up the problem, were getting if we dont clean up & move ove

Not moving templates over based on the assumption that nobody wanna do an admin theme & therefor it should not be in classy is gonna burn us down the road.
- classy is where all classes that drupal uses for visual elements as decided by the banana concensus
- it makes a false assumption of "what a themer might wanna do" (yes an admin theme needs love to)
- update is one of the templates / css that any admin theme is gonna use a lot of time
- makes it harder for seven & other admin themes to know whats the exact markup is & why isnt that in classy
- Drupals default admin theme is seven & is building on classy, having a strange seperation all the way into stark, cause its "admin" makes no logical sense
- Admin themes need's love & classy to

lauriii’s picture

Component: theme system » Classy theme
joelpittet’s picture

Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.