Onceis committed, we should be able to remove these functions and the whole concept of an override free config factory.
It should still be possible to get editable configuration objects override free but the state should not settable. This will help us prevent unexpected usage of override free configuration objects. For example, if you create a config event listener the config factory will be in an override-free state for the save and delete events but not for rename. The save and delete events should have the override-free config object but all other configuration obtained from the factory should have overrides.
Remove the methods.
On commit add this issue to the CR https://www.drupal.org/node/2407153
User interface changes
Removed ConfigFactory::setOverrideState and ConfigFactory::getOverrideState()
Beta phase evaluation
|Issue category||Bug because a stateful config factory is problematic. It makes unintentional side effects very difficult to avoid.|
|Issue priority||Critical because config CRUD events are runtime actions but the config factory is in override free state.|
|Disruption||Disruptive for anything that use setOverrideState or getOverrideState. This is mitigated by the fact that these should probably be using ConfigFactory::getEditable() anyway.|