Problem/Motivation

To prevent a dependency on block entities in block templates/preprocessing, we made the id optional. However, it looks like the mentioned template file is still relying on, resulting in invalid and duplicate ID's in case you are using a menu block in a context where no ID is provided (e.g. with page_manager).

Proposed resolution

Not sure how to fix this, can we use the derivative plugin ID there somehwere? Might not be unique, though.

I once discussed with @timplunkett about being able to rely on a unique ID for blocks and make whoever is using block plugins responsible for setting one. i thought I opened an issue, but I had no luck at all at finding that again.

Remaining tasks

User interface changes

API changes

Comments

Wim Leers’s picture

Issue tags: +accessibility

I added this; it's necessary for accessibility. If you have another way of generating a (sufficiently, i.e. not accounting for crazy edge cases) unique ID, then that'd be fine.

Cottser’s picture

Issue tags: +Twig

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.