User roles Views argument handler missing/broken

+++ b/core/modules/user/src/Plugin/views/argument/RolesRid.php
@@ -17,7 +17,7 @@
- * @ViewsArgument("user__roles_rid")
+ * @ViewsArgument("user__roles_target_id")
  */
 class RolesRid extends ManyToOne {

Seriously, who reviewed that, before it got in :( ... I would vote to rename it back to "user_roles" and be done with it.

Ah mh, well at least let's ensure that we add tests later

1. +++ b/core/modules/user/src/Plugin/views/argument/RolesRid.php
   @@ -50,7 +50,7 @@ public function __construct(array $configuration, $plugin_id, $plugin_definition
      public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
   -    return parent::create($container, $configuration, $plugin_id, $plugin_definition, $container->get('entity.manager'));
   +    return new static($configuration, $plugin_id, $plugin_definition, $container->get('entity.manager'));
      }
   

   Ha!

2. +++ b/core/modules/user/src/Tests/Views/HandlerArgumentUserRoleTest.php
   @@ -0,0 +1,46 @@
   +  /**
   +   * @file
   +   * Contains \Drupal\user\Tests\Views\HandlerArgumentUserRoleTest.
   +   */
   

   Let's remove the indentation here

3. +++ b/core/modules/user/src/Tests/Views/HandlerArgumentUserRoleTest.php
   @@ -0,0 +1,46 @@
   +/**
   + * Tests the handler of the user: role Argument.
   + *
   + * @group user
   + */
   +class HandlerArgumentUserRoleTest extends UserTestBase {
   +
   

   It would be nice to have a @see to the actual class.

4. +++ b/core/modules/user/src/Tests/Views/HandlerArgumentUserRoleTest.php
   @@ -0,0 +1,46 @@
   +  /**
   +   * Tests the user: role argument.
   +   */
   +  public function testArgumentTitle() {
   

   Okay fine, and helpful, we check the execution, but we don't check the argument title, as the method kind of implies.

5. +++ b/core/modules/user/src/UserViewsData.php
   @@ -306,7 +306,7 @@ public function getViewsData() {
   -        'id' => 'user__roles_target_id',
   +        'id' => 'user__roles_rid',
   

   Its still sad to have such a plugin ID. If you look at the existing code in RolesRid nothing of that is tied to the user__roles table. It would be nice to name it 'user_roles' so, its a generic handler, so let's name it generic.