On user registration help text for username field contains semi-colon it should be comma.

Steps to re-produce

1. Go to /user/register
2. Look for help text under username field after "Sapaces are allowed" text there is a semi-colon

CommentFileSizeAuthor
#8 After_patch_semicolon_not_displayed.JPG18.19 KBTrupti Bhosale
#8 Before_patch_semicolon_displayed.JPG16.29 KBTrupti Bhosale
#4 semi-colon-be-gone.png17.43 KBlammensj
#3 After applying Patch .png152.65 KBNikitaJain
#2 text-registration-page-2405449-1.patch799 bytesPoornima3
#2 text-registration-page-2405449-1.patch799 bytesPoornima3

Comments

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Active » Needs review
StatusFileSize
new registration_username_helptext-2405449-1.patch1.73 KB

Submitting patch for the issue.

Poornima3’s picture

Poornima3 commented
StatusFileSize
new text-registration-page-2405449-1.patch799 bytes
new text-registration-page-2405449-1.patch799 bytes

Replaced the semi-colon with a comma

NikitaJain’s picture

NikitaJain commented
Status: Needs review » Needs work
StatusFileSize
new After applying Patch .png152.65 KB

Tested the above patch text-registration-page-2405449-1_0.patch. Its not working fine. I can see the semi-colon in username field help text registration page "Spaces are allowed; " after applying the patch. Tested on chrome & Firefox Ubuntu 14.04
Screenshot attached.

lammensj’s picture

lammensj commented
StatusFileSize
new semi-colon-be-gone.png17.43 KB

I can confirm that the patch is working, not seeing any semi-colon in the description.

lammensj’s picture

lammensj commented
Status: Needs work » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

Semi-colons are valid punctuation...

The semicolon or semi-colon (;) is a punctuation mark that separates major sentence elements. A semicolon can be used between two closely related independent clauses, provided they are not already joined by a coordinating conjunction.

I'm not sure that this is incorrect.

lammensj’s picture

lammensj commented

Perhaps we should just leave it like it is. After reading through, a colon might be too soft and a period perhaps too strong.
In dutch we probably would have written this with a semi-colon because it is a list of something.

Trupti Bhosale’s picture

Trupti Bhosale commented
StatusFileSize
new Before_patch_semicolon_displayed.JPG16.29 KB
new After_patch_semicolon_not_displayed.JPG18.19 KB

Verified the fix with the patch 'text-registration-page-2405449-1.patch' and it is working fine.Semicolon after 'Spaces are allowed' is removed and comma is displayed.Verified on Firefox & Chrome on Windows 8.
Attached snapshot for reference.

Trupti Bhosale’s picture

Trupti Bhosale commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

@Truptti yes the patch works but your comment does not address #6. Is the removal grammatically correct?

Trupti Bhosale’s picture

Trupti Bhosale commented

@alexpott :yes your right.
I came across an issue related to punctuation,please refer this https://www.drupal.org/node/827468

no_angel’s picture

no_angel commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -#dcdelhi, -registration, -Help text

Suggest changing Status to Closed (won't fix) or (works as designed)?

cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Closed (duplicate)

Actually, this is a duplicate.