Remove usage of taxonomy_term_load_parents()

1. +++ b/core/modules/forum/src/Form/ForumForm.php
   @@ -129,7 +129,7 @@ protected function actions(array $form, FormStateInterface $form_state) {
   -    $parents = taxonomy_term_load_parents($tid);
   +    $parents = \Drupal::entityManager()->getStorage('taxonomy_term')->loadParents($tid);
   

   Should be injected.

2. +++ b/core/modules/taxonomy/src/Entity/Term.php
   @@ -67,7 +67,7 @@ public static function postDelete(EntityStorageInterface $storage, array $entiti
   -          $parents = taxonomy_term_load_parents($child->id());
   +          $parents = \Drupal::entityManager()->getStorage('taxonomy_term')->loadParents($child->id());
   

   use $this->entityManager() instead of \Drupal::entityManager()

3. +++ b/core/modules/taxonomy/src/TermForm.php
   @@ -23,7 +23,7 @@ public function form(array $form, FormStateInterface $form_state) {
   -    $parent = array_keys(taxonomy_term_load_parents($term->id()));
   +    $parent = array_keys(\Drupal::entityManager()->getStorage('taxonomy_term')->loadParents($term->id()));
   
   @@ -34,12 +34,12 @@ public function form(array $form, FormStateInterface $form_state) {
   -      $parent = array_keys(taxonomy_term_load_parents($term->id()));
   +      $parent = array_keys(\Drupal::entityManager()->getStorage('taxonomy_term')->loadParents($term->id()));
   

   Should be $this->entityManger->getStorage(...

4. +++ b/core/modules/taxonomy/src/TermForm.php
   @@ -34,12 +34,12 @@ public function form(array $form, FormStateInterface $form_state) {
   -    // taxonomy_get_tree and taxonomy_term_load_parents may contain large
   +    // taxonomy_get_tree and \Drupal::entityManager()->getStorage('taxonomy_term')->loadParents() may contain large
   

   Too long and we could change this to just say that the term's might have a large number of parents.

@alexpott all the changes has been done.

Tags are separated with a comma, not a space.

No longer applies.

Reroll attached.

Needs a reroll.

$ git apply remove-usage-of-taxonomy-term-load-parents-2405365-12.patch 
error: patch failed: core/modules/migrate_drupal/src/Tests/d6/MigrateTaxonomyTermTest.php:99
error: core/modules/migrate_drupal/src/Tests/d6/MigrateTaxonomyTermTest.php: patch does not apply
error: patch failed: core/modules/taxonomy/src/Tests/TaxonomyTermIndentationTest.php:56
error: core/modules/taxonomy/src/Tests/TaxonomyTermIndentationTest.php: patch does not apply

Also a minor coding standards thing:

+++ b/core/modules/taxonomy/src/TermForm.php
@@ -34,12 +34,12 @@ public function form(array $form, FormStateInterface $form_state) {
+    // the term's might have a large number of parents.
+    // so we check for taxonomy.settings:override_selector

Needs capitalization, punctuation, and wrap at 80 chars.

Isn't this a duplicate of https://www.drupal.org/node/2452577 ?

Indeed it is. Either #2452577: Remove Usage of deprecated function taxonomy_* is the duplicate, or this one is.

I'd say the other one has more stuff done and a wider scope, even though it's newer.

Yep, let's close this as a duplicate of that one, because we need to get the taxonomy storage for all four of the deprecated functions, so it makes sens to do it in one patch. Closing this as a duplicate of that one.