I have problems getting the module installed. Drupal would not let me activate it at all and I always get the message: The GeoIP database file is missing or not configured. Download the latest file at ...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aagd’s picture

Issue summary: View changes
aagd’s picture

Issue summary: View changes
tezalsec’s picture

Same here.

Checks for values in variables_get in install file while variables were never set and dont exist ;-/
Quite a critical bug, install file seems not tested and for two months no reply on previous comment.. too bad.

tezalsec’s picture

Got it to work by just creating the variable or executing the following php code somewhere, then install module again.

variable_set('geoip_data_file', 'sites/all/libraries/geoip/GeoLiteCity.dat');

(possibly your .dat file has a different name, change accordingly)

netdreamer’s picture

Status: Active » Needs review
FileSize
817 bytes

There is no need to force a specific value for the variable by hand: the problem is in the implementation of the geoip_requirements(), that is too much restrictive on the initial phase.

I fixed it with a small patch that lowers severity requirements for the missing GeoIP DB file to Informational (now it was Error) while on the install phase, so that it can later be set with the standard module admin GUI.

tezalsec’s picture

That should do it, thanks!

saveva’s picture

The netdreamer patch didn't work for me! The problem resides in the variable_get for geoip_data_file. Once you configure a default value there things run smoothly.

Code change needed on line 50 of geoip.install:

  if (!($file = variable_get('geoip_data_file', 'sites/all/libraries/geoip/GeoLiteCity.dat')) || !file_exists($file)) {

  • das-peter committed 086f372 on
    Issue #2404869 by netdreamer, aagd, Maxim75, avevas: Module doesn't...
das-peter’s picture

Status: Needs review » Fixed

Just pushed a mixed fix.
The check now only runs during runtime. I don't thing it makes sense earlier - no matter what severity would be reported.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.