I spent some time getting the ctools modals to work better with a fixed navbar. On small screens or with a large navbar, the modal can slip behind the nav. I've updated the JS to look for body padding-top and to adjust accordingly by adding the same top-padding to the modal container and reducing the modal's height by the same amount.

While I was at it, I changed the the .modal-body to a max-height instead of height. Now the modal only takes up the room it needs and we don't have that ugly vertical whitespace.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frankcarey’s picture

Issue summary: View changes
frankcarey’s picture

This patch is the JShint cleanup of the code.

frankcarey’s picture

Status: Active » Needs review
markhalliwell’s picture

Status: Needs review » Fixed

  • markcarver committed c63f9b1 on 7.x-3.x authored by frankcarey
    Issue #2404405 by frankcarey: Allow modal to handle fixed navbar and...

  • markcarver committed 6af03d7 on 8.x-3.x authored by frankcarey
    Issue #2404405 by frankcarey: Allow modal to handle fixed navbar and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.