The advagg_js_compress_prep() function adds comment lines at the beginning and end of each compressed Javascript file with links to the original file from which they were derived. This arguable improves GPL compliance of the module. However, the comments also generate some warnings from automated security scans such as Cenzic. To provide flexibility, therefore, the question of whether or not to add the licensing comments ought to be configurable.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sheldon Rampton’s picture

Status: Active » Needs review
FileSize
864 bytes

I see that this was already partly implemented in a previous commit: https://www.drupal.org/files/issues/advagg-2295757-5-option-to-remove-li...

Here's a patch to make the variable configurable via the module's web settings interface.

mikeytown2’s picture

Original issue on the subject of GPL & js minification #1493876: Better GPL compliance when using JS minification

mikeytown2’s picture

Status: Needs review » Fixed
FileSize
1.64 KB

Moved the patch to the advagg_js_compress module

  • mikeytown2 committed 2ad1667 on 7.x-2.x
    Issue #2402367 by Sheldon Rampton, mikeytown2: Make "add licensing" a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.