Problem/Motivation

When displaying a View with a bulk update field an "empty" bulk form field is shown when there are no actions available (see image below). This can happen when access to available actions is restricted as proposed in #2172017: Bulk operations does not respect entity access between #19 and #89. It can also happen when a bulk update field is added to the View, but no actions are selected in the field's settings (though I would call this a misconfiguration).

How to reproduce

The easiest way to reproduce:

  1. Create a View with a bulk update field.
  2. On the bulk update field settings, for "Available actions" choose "Only selected actions" and for "Selected actions" uncheck all.
  3. Display the View.

Proposed resolution

The bulk form field should not be rendered when there are no actions available.

Remaining tasks

TBD.

User interface changes

The bulk form field will not be shown if there are no actions available.

API changes

None.

CommentFileSizeAuthor
#20 Screenshot 2023-08-05 at 20-14-04 Content dev2-web.png7.11 KBquietone
#10 2402155-10.patch1.4 KBnikita_tt
2172017-79-empty-bulk-operations-list.png32.41 KBMegaChriz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz commented
Issue summary: View changes
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Postponed » Active

Ok, I think since that issue is fixed we can work on this one.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz commented

Note that until #91 #2172017: Bulk operations does not respect entity access was about two issues in one:

  1. Check access for which of the operations the current user may use at all (no individual entity context).
  2. Check if the selected operation may be performed for each selected entity in the View.

Issue 2 was what the issue was originally about and also what was fixed. When proposal fixes for issue 1 where posted in that issue, the problem reported in this issue (empty bulk form field) came to light. I'm not sure if there is a follow-up issue created for issue 1 (restrict access to available operations). If there is none and if that issue somehow became obsolete, then this issue can only be reproduced by creating a bulk update field with no actions selected (see issue summary). In that case I would judge this issue as a misconfiguration.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
CreditAttribution: nikita_tt at DevBranch commented
FileSize
2402155-10.patch1.4 KB

I guess "#emtpy_option" handles the issue.

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
CreditAttribution: nikita_tt at DevBranch commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: 2402155-10.patch, failed testing. View results

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Issue tags: +Needs tests

The tests need to be updated for this, but there also should be specific testcoverage added for this new value as well.

1. action\Functional\BulkFormTest -> The assertion should be updated.
2. node\Functional\Views\BulkFormTest -> The assertions should be updated.
3. \views\Functional\Plugin\ViewsBulkTest -> I don't know why this test is failing, but it must be related because it's in views bulk as well.
4. media_library\FunctionalJavascript\MediaLibraryTest -> This looks like it was a random failure.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes
Status: Needs work » Closed (outdated)
FileSize
Screenshot 2023-08-05 at 20-14-04 Content dev2-web.png7.11 KB

I tested this on Drupal 11.x, standard install, using the steps in the IS. I generated content with devel_generate and made a new test view. Here is a screenshot of the the bulk action selection now.

Because of that I am closing this as outdated.