Problem/Motivation

In the sms_actions trigger page admin/structure/trigger/sms_actions there is a trigger that says "TRIGGER: WHEN AN SMS MESSAGE WITH ANY DISCRIMINATOR IS RECEIVED". However, this trigger doesn't work and actions assigned to it will not be triggered when an sms with "ANY" discriminator is received.
Found this while writing tests for sms_actions.module.

Proposed resolution

Fix the bug so the "Any discriminator" trigger will work as specified.

Remaining tasks

Patch (with tests).
Review
Commit

User interface changes

API changes

CommentFileSizeAuthor
#3 sms_actions_any_discriminator-2401697-3.patch1.92 KBalmaudoh
#3 interdiff.txt1.32 KBalmaudoh
#1 sms_actions_any_discriminator-2401697-1-fail.patch1.22 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Active » Needs review
FileSize
sms_actions_any_discriminator-2401697-1-fail.patch1.22 KB

Added a test without the fix. This patch should fail.

Status: Needs review » Needs work

The last submitted patch, 1: sms_actions_any_discriminator-2401697-1-fail.patch, failed testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.32 KB
sms_actions_any_discriminator-2401697-3.patch1.92 KB

Updated test and applied fix.

almaudoh queued 3: sms_actions_any_discriminator-2401697-3.patch for re-testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Fixed

Committed / pushed to 7.x-1.x

  • almaudoh committed 01dd7a8 on 7.x-1.x 
    Issue #2401697 by almaudoh: SMS Actions "Any discriminator" trigger not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.