Opening this as a follow-up request to #2312729: "Number of values to display" has no effect in View. It would reduce confusion to prevent these two form fields from appearing in the views settings for an individual field, since they have no effect, yet appear more prominently than Views' own settings which implement this.

CommentFileSizeAuthor
#9 2400517-changes_in_views_settings-9.patch2.56 KBchishah92
#6 2400517-changes_in_views_settings-6.patch1.93 KBchishah92
#4 2400517-changes_in_views_settings-4.patch1.19 KBchishah92
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

t_en’s picture

t_en CreditAttribution: t_en commented

I second this! The current setup is very confusing.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Version: 7.x-1.0-alpha4 » 7.x-1.x-dev
Category: Feature request » Bug report
Priority: Minor » Normal

I agree this is an important fix. Because views is so widely used, I'm upping this to normal priority from minor, and marking it as a bug.

Are there other good examples of modules that exclude their settings from views? Maybe we could see what kind of implementation there is for that.

Unfortunately I'm not sure that I have the capacity to write a patch for this at the moment, but if anyone else does I will happily review.

chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Assigned: Unassigned » chishah92
chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Status: Active » Needs review
FileSize
2400517-changes_in_views_settings-4.patch1.19 KB

Added a patch with the changes.

Thanks!
~Chirag

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Status: Needs review » Needs work

@chishah92 Thanks for your contribution!

Unfortunately, this removes the field settings from everywhere -- it basically removes them from the module. We just want to omit them when it appears in a views field setting.

chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Status: Needs work » Needs review
FileSize
2400517-changes_in_views_settings-6.patch1.93 KB

The new patch omits the same.

Thanks!
~Chirag

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Status: Needs review » Needs work

Very nice!

One request: Let's exclude the new 'field_multiple_limit_order' settings as well.

And one very small nitpick: Use single quotes rather than double quotes to stay consistent with what's already there.

I'm going to let you take care of this so you get all the issue credit :)

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Parent issue: » #2807565: [meta] 7.x beta release roadmap
chishah92’s picture

chishah92 CreditAttribution: chishah92 at Blisstering Solutions commented
Status: Needs work » Needs review
FileSize
2400517-changes_in_views_settings-9.patch2.56 KB

Have updated the changes in this new patch.

Thanks!
~Chirag

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented

Looks great. I'm going to leave it here for 24 hours in case anyone else wants to review, and then I'll mark as RTBC and commit.

Thanks for your work on this!

mayurjadhav’s picture

mayurjadhav CreditAttribution: mayurjadhav at Blisstering Solutions commented

Looks great. +1 for RTBC.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Status: Needs review » Reviewed & tested by the community

Thanks for the additional review! Will commit this later today.

  • rootwork committed 7fc3082 on 7.x-1.x authored by chishah92 
    Issue #2400517 by chishah92: Remove "Number of values to display" and "...
rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.