Case study URL: https://www.drupal.org/node/2399723

Website URL: http://landscapeperformance.org/

Hello,

I'm requesting a review of the Landscape Performance Series Drupal 7 website case study I created.

The site uses a lot of contributed modules that are detailed in the "Why these modules/theme/distribution were chosen" section. We didn't have any community contributions though. We used a handful of patches found in the forums but nothing that we ourselves submitted. Let me know if you have any questions or comments.

Thanks!
Daniel

Comments

leighcan’s picture

Hi Daniel,

I'll check over this as soon as possible. It may be closer to DrupalCon Latin America before I can get to it, but I just wanted to drop you a line and let you know that this is on my radar. Another community member may get to it first, and if not, you can help this process along by encouraging more participation & getting involved in content review. You can learn more about that here.

Cheers,
Leigh

rickdonohoe’s picture

Hi Daniel,

I've taken a look at this for you, could I request you help me out too and check this one out for me? - https://www.drupal.org/node/2428133

Your case study reads quite well. I like how you have described a little about the project style (agile, 2.5 months etc) and I think the Views write-up is well detailed and helpful for others who are looking to do the same sort of thing. Personally I think full module listing's aren't too necessary since explaining what commonly used modules do is a bit of a waste of time in my opinion, but you've done a very comprehensive job of that and I'm sure inexperienced developers will certainly appreciate that.

There were a couple of things I was asking myself as I read through this:

Where is it hosted? I understand the PM workflow, but what about the development workflow?
You mention Migrate and custom CMS a few times - what is the custom CMS? Was there any specific challenges with this part?
Are you the only person on the project with a d.org account?

The only thing I can say is that I'm debating how well the site itself reflects a Featured status, specifically to the following guideline -

"It's an outstanding example of a Drupal site. This means it's pushed the boundaries of performance, design, interaction, customization, or third-party integration."

I think the site looks awesome and you've done a great build job, but there's quite few fundamental things that I think it lacked which made me think it didn't quite hit the guideline mark mentioned above:

1. It's a shame the site isn't responsive. I'm guessing a lot of time and attention has been spent on the design and themeing so that addition would be awesome!

2. A lot of font's used are around 10px and I find them quite hard to read. The bold white text style on the yellow background also really doesn't work for me as I have to concentrate hard to read it.

3. The site logo overlaps a lot of content when scrolling down pages. I have a 1900px monitor and that is only slightly a problem there, but at any smaller screen-sizes it actually makes reading the text a problem! Is this design or a bug?!

Anyway, that's my contribution. I'm not saying the points above DON'T make it a featured case study as they are subjective, but I'd be interested to see what other reviewers think.

If you can grab a couple of +1's I can update you to Featured. Best of luck!!

Rick

leighcan’s picture

Status: Needs review » Needs work

Hi Daniel, thanks for your patience!

The case study looks good to me -- however, please make sure you address Rick's concerns above. Once that's done, we'll look at bumping you to featured. +1 from me.

-Leigh

Daniel Korte’s picture

Thanks Rick. Sorry, I got to this too late to check out your case study — it looks like you have two +1's. Congrats!

Actually, we've only highlighted the modules that we felt would be of interest to people. Some of the usual suspects were left out (ctools, date, entity, field_group, globalredirect, link, etc.)

It is hosted on MediaTemple, but I'm not sure that is necessary? Under the 'Describe the project' section there is a 'Development' section that I think details our development workflow pretty well. Is there something in particular you thought was missing? I ask because I'm not sure what else to include...

The custom CMS is a proprietary CMS that is owned by the company I work for: TOKY Branding + Design. There isn't a link to it anywhere on the web so no one has ever heard of it, hence the "custom CMS" designation. The only specific challenge was migrating the content which I explain in that section along with the link to the custom module on Github.

Yes, I'm the only person with a drupal.org account.

1. The client is looking into a responsive version in a future phase of design & development, but at this time that does not have a date set.

2. Hm, I'm not sure what you are referring to with the 10px type, most of the font sizes are 11 pixels or larger. Also, I'm not sure I can do anything about the yellow/white text at this point since the client already signed off on the overall design.

3. The site logo overlap was a design decision, but the client has decided to remove the overlap which we will be updating in the next few weeks.

Thanks again!

Daniel Korte’s picture

Status: Needs work » Needs review
dddave’s picture

+1 for featured

rickdonohoe’s picture

Status: Needs review » Closed (fixed)

Hi Daniel,

Thanks for the reply. My case study still hasn't had a US grammar check, so I'd still be grateful if you could give it a read over!

I think with hosting it can be good to mention benefits of choosing a specific solution but that would only be if it was worthwhile. If you went with say Acquia, Pantheon, Aberdeen Cloud, or some other Drupal hosting platform then I guess this there are benefits to discuss, but likely not with MediaTemple so no worries. Weirdly their landing page is Hosting for Wordpress sites, blasphemy!!

I think elements of design are of course subjective and I know the issues after signed off design workflow so nothing to add there. I just thought it would be worth pointing them out as feedback.

Based on your answers my only outstanding point would be too add something about the proprietary CMS (even just a couple of sentences), because if I'm asking then you can be damn sure others will.

Since that point is fairly minor I'll bump you now. Congrats!

Daniel Korte’s picture

Thanks everyone!

@rick - I added a few lines about the previous CMS: "The fact that the previous solution, our own proprietary CMS, was also PHP/MySQL based (like our Drupal install) made the transition smooth as well. Overall, the previous CMS was somewhat similar to WordPress."