The patch definitely worked for me.
Tested on Drupal 8.7.x and 8.8.x.

RTBC! Thanks!

CommentFileSizeAuthor
#31 order_with_patch.png9.77 KBcolin.eininger
#31 order_without_patch.png9.76 KBcolin.eininger
#18 2396923-18.patch783 bytesAardWolf
#9 2396923-table_sort.patch1.19 KBAndrej Galuf
table-sort.patch1 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, table-sort.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Could you add steps to reproduce?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Just use table form element type and set different weight for the rows. They will be displayed in the way they were added into the form instead of sorted by the weight value.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented

I can confirm that this is still an issue in 8.2.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Andrej Galuf’s picture

Andrej Galuf CreditAttribution: Andrej Galuf commented
FileSize
2396923-table_sort.patch1.19 KB

I just got hit by this issue myself when trying to implement a quick tablesort.As this effectively breaks tablesort in Form API, here's a quick reroll of the patch in OP against latest code.

Andrej Galuf’s picture

Andrej Galuf CreditAttribution: Andrej Galuf commented
Status: Needs work » Needs review

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

stmh’s picture

stmh CreditAttribution: stmh at Factorial GmbH for Mediagroup KLAMBT commented

Patch works as expected on my end.

stmh’s picture

stmh CreditAttribution: stmh at Factorial GmbH commented

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

rli’s picture

rli
Primary language English
Location Canberra
CreditAttribution: rli as a volunteer commented

The path in #9 worked for me.

jonnyeom’s picture

jonnyeom CreditAttribution: jonnyeom as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
AardWolf’s picture

AardWolf CreditAttribution: AardWolf at ADCI Solutions commented
FileSize
2396923-18.patch783 bytes

I think that tables don't need to be sorted always.
My solution is don't touch #sorted property in the form builder,
so if it was set up then a table or any other element will be sorted.
If it wasn't set up then there will be old logic of sorting.

AardWolf’s picture

AardWolf CreditAttribution: AardWolf at ADCI Solutions commented
Status: Reviewed & tested by the community » Needs review

Status: Needs review » Needs work

The last submitted patch, 18: 2396923-18.patch, failed testing. View results

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Anas_maw’s picture

Anas_maw CreditAttribution: Anas_maw as a volunteer commented
Status: Needs work » Reviewed & tested by the community

Patch in #9 works as expected.
Patch in #10 does not work, and I think table rows should always be sorted when we have a #weight variable.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 2396923-18.patch, failed testing. View results

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

dennis_meuwissen’s picture

dennis_meuwissen CreditAttribution: dennis_meuwissen commented

Can also confirm that patch #9 works, with Drupal 8.9.16.

AardWolf’s picture

AardWolf CreditAttribution: AardWolf at ADCI Solutions commented
wesleyl’s picture

wesleyl CreditAttribution: wesleyl at CI&T commented
Status: Needs work » Reviewed & tested by the community

Tested patch #9 on Drupal 9.1.11 and work as expected.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Reviewed & tested by the community » Needs work

Tests are not passing, we cannot commit any patch without tests in green.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Version: 8.9.x-dev » 9.1.x-dev
Status: Needs work » Reviewed & tested by the community

Ah! Patches in #18 are not valid. The patch to review is #9. Sorry for the noise.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests, +Needs issue summary update

The patch in #9 needs to tests to show the bug and prove that it has fixed them. Also the issue summary could do with more detail.

colin.eininger’s picture

colin.eininger CreditAttribution: colin.eininger commented
FileSize
order_without_patch.png9.76 KB
order_with_patch.png9.77 KB

I'm facing this issue in Drupal 9.2.6, but just figured out that patch #9 introduced a new bug in the administration menus.

To reproduce:

  • Create a new instance of drupal 9.3.x (tested with 9.2.6 and 9.3.x)
  • Apply the patch #9
  • Create a new menu
  • Add at least 2 main items
  • Add at least 3 childs in the first main item

Resulting in children being split between all main items (see attached screenshots).

Version: 9.1.x-dev » 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

JI_Gravityworks’s picture

JI_Gravityworks
she/her
Location Michigan
CreditAttribution: JI_Gravityworks at Gravity Works Design + Development commented

Seeing the same issue as reported in #31 -- used the patch in #9 to fix an error with the Redirect Page By Role module, but it completely re-arranged all of our second- and third-level navigation. Using 9.3.9 currently.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.