The Installation section for the main page of this module instructs you to create modernizr.min.js, but when I enabled this module it created modernizr-latest.js, which appears to work. It's not a problem, it's just a bit confusing.

CommentFileSizeAuthor
#5 2395841-5-instructions.patch1.01 KBrupl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rupl’s picture

Category: Feature request » Support request

Did you use Drush? Upon enabling the module, Drush automatically downloads the "development" copy of Modernizr from http://modernizr.com/downloads/modernizr-latest.js which contains all the available tests, but does NOT contain Modernizr.load(). If you go to /admin/config/development/modernizr you will see a page which allows you to build a much smaller, customized copy of Modernizr that also includes Modernizr.load()

youngelpaso’s picture

I second that, I had the same experience.

rupl’s picture

To be honest I need some direction on what it should say. I wrote the module and have had an extremely clear understanding of how it works since the beginning. So if you provide me with the instructions you want to see (or patch them in!) then I'm happy to review and make the installation process more helpful.

versantus.nik’s picture

How about rather than
"You don't seem to have a custom build of Modernizr installed yet. This page will help generate one for you."

say:
"You don't seem to have a custom build of Modernizr installed yet, or we have detected the wrong version. Remove any existing modernizer-latest.js or modernizer custom builds from sites/all/libraries and generate a new one using the instructions below."

rupl’s picture

Status: Active » Needs review
FileSize
1.01 KB

Thanks for the feedback, how is this?

versantus.nik’s picture

Status: Needs review » Reviewed & tested by the community

That wording looks good and the patch worked for me.

  • rupl committed 390bb1e on 7.x-3.x
    Issue #2395841 by rupl, versantus: Better instructions for installing a...
rupl’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.