Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Note: The 8.x-3.x branch is being rebuilt (see #2390997: Upgrade 7.x structure to 8.x structure) because it has become so out of sync from the 7.x-3.x branch.
Comment | File | Size | Author |
---|---|---|---|
#21 | update_registry_to_work-2393767-7.patch | 132.18 KB | neardark |
Comments
Comment #1
neardark CreditAttribution: neardark commentedComment #2
neardark CreditAttribution: neardark commentedComment #4
neardark CreditAttribution: neardark commentedComment #5
neardark CreditAttribution: neardark commentedComment #7
neardark CreditAttribution: neardark commented*sigh*
Comment #8
neardark CreditAttribution: neardark commentedComment #10
gregnostic CreditAttribution: gregnostic commentedStray console.log
Indent an additional level inside the conditional structure.
Also needs more indentation.
And again.
Extra space before endif.
Indentation is messed up.
This needs something done about it, whether it's removal or doing the work to fix it.
Is this needed?
There's a tremendous amount of commented-out code here.
Is this something that could be done in code rather than the template? This doesn't seem like the best place for it.
Needs another level of indentation.
More commented-out code.
Indentation is off.
More commented-out code.
More commented-out code.
More commented-out code.
More commented-out code.
More commented-out code.
Extra space before the if.
Extra space before the endif.
This comment is not correct.
This comment is not correct.
More commented-out code.
Needs to be indented.
Comment #11
neardark CreditAttribution: neardark commentedComment #12
neardark CreditAttribution: neardark commentedComment #13
neardark CreditAttribution: neardark commentedComment #15
neardark CreditAttribution: neardark commentedComment #16
neardark CreditAttribution: neardark commentedComment #18
neardark CreditAttribution: neardark commentedComment #19
neardark CreditAttribution: neardark commentedComment #20
neardark CreditAttribution: neardark commentedComment #21
neardark CreditAttribution: neardark commentedComment #22
gregnostic CreditAttribution: gregnostic commentedComment #25
markhalliwellCommitted #2098551: Registry alter does not keep proper order of [pre]process functions to the 8.x branch. Not sure if this issue is still CNW or not, so I'm not going to touch the status.
Comment #26
markhalliwell