Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neardark’s picture

neardark’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: update_registry_to_work-2393767-1.patch, failed testing.

neardark’s picture

neardark’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: update_registry_to_work-2393767-2.patch, failed testing.

neardark’s picture

*sigh*

neardark’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: update_registry_to_work-2393767-3.patch, failed testing.

gregnostic’s picture

  1. +++ b/docroot/themes/bootstrap/js/misc/_vertical-tabs.js
    @@ -1,116 +1,132 @@
    +          console.log('hee');tab_list.append(vertical_tab.item);
    

    Stray console.log

  2. +++ b/docroot/themes/bootstrap/templates/bootstrap/bootstrap-panel.html.twig
    @@ -0,0 +1,34 @@
    +    <legend class="panel-heading">
    

    Indent an additional level inside the conditional structure.

  3. +++ b/docroot/themes/bootstrap/templates/bootstrap/bootstrap-panel.html.twig
    @@ -0,0 +1,34 @@
    +    <legend class="panel-heading">
    

    Also needs more indentation.

  4. +++ b/docroot/themes/bootstrap/templates/bootstrap/bootstrap-panel.html.twig
    @@ -0,0 +1,34 @@
    +  <div class="panel-collapse collapse fade{{ collapsed ? in : '' }}">
    

    And again.

  5. +++ b/docroot/themes/bootstrap/templates/bootstrap/bootstrap-panel.html.twig
    @@ -0,0 +1,34 @@
    +  {%  endif %}
    

    Extra space before endif.

  6. +++ b/docroot/themes/bootstrap/templates/bootstrap/bootstrap-panel.html.twig
    @@ -0,0 +1,34 @@
    +    {% if collapsible %}
    

    Indentation is messed up.

  7. +++ b/docroot/themes/bootstrap/templates/system/breadcrumb.vars.php
    @@ -16,12 +16,13 @@ function bootstrap_preprocess_breadcrumb(&$variables) {
    +//  if (theme_get_setting('bootstrap_breadcrumb_title') && !empty($breadcrumb)) {
    

    This needs something done about it, whether it's removal or doing the work to fix it.

  8. +++ b/docroot/themes/bootstrap/templates/system/details.vars.php
    @@ -0,0 +1,13 @@
    +  // @todo: This is not getting called. Why?
    

    Is this needed?

  9. +++ b/docroot/themes/bootstrap/templates/system/fieldset.vars.php
    @@ -0,0 +1,111 @@
    +//  $element = $variables['element'];
    

    There's a tremendous amount of commented-out code here.

  10. +++ b/docroot/themes/bootstrap/templates/system/form-element-label.html.twig
    @@ -0,0 +1,32 @@
    +set classes = [
    

    Is this something that could be done in code rather than the template? This doesn't seem like the best place for it.

  11. +++ b/docroot/themes/bootstrap/templates/system/form-element-label.html.twig
    @@ -0,0 +1,32 @@
    +    <p class="help-block">{{ description }}</p>
    

    Needs another level of indentation.

  12. +++ b/docroot/themes/bootstrap/templates/system/form-element.vars.php
    @@ -0,0 +1,167 @@
    +  //  if ((isset($element['#parents']) && form_get_error($element)) || (!empty($element['#required']) && theme_get_setting('bootstrap_forms_required_has_error'))) {
    

    More commented-out code.

  13. +++ b/docroot/themes/bootstrap/templates/system/form-element.vars.php
    @@ -0,0 +1,167 @@
    +        ' ' => '-',
    

    Indentation is off.

  14. +++ b/docroot/themes/bootstrap/templates/system/form-element.vars.php
    @@ -0,0 +1,167 @@
    +//  $prefix = '';
    

    More commented-out code.

  15. +++ b/docroot/themes/bootstrap/templates/system/form-element.vars.php
    @@ -0,0 +1,167 @@
    +//  switch ($element['#title_display']) {
    

    More commented-out code.

  16. +++ b/docroot/themes/bootstrap/templates/system/form-element.vars.php
    @@ -0,0 +1,167 @@
    +//  if (!empty($element['#type']) && $element['#type'] === 'fieldset') {
    

    More commented-out code.

  17. +++ b/docroot/themes/bootstrap/templates/system/input.vars.php
    @@ -0,0 +1,85 @@
    +//  if (isset($element['#type']) && $element['#type'] === 'text_format') {
    

    More commented-out code.

  18. +++ b/docroot/themes/bootstrap/templates/system/mark.vars.php
    @@ -0,0 +1,20 @@
    +//  if ($user->uid) {
    

    More commented-out code.

  19. +++ b/docroot/themes/bootstrap/templates/system/page.html.twig
    @@ -0,0 +1,152 @@
    +      {%  if logo %}
    

    Extra space before the if.

  20. +++ b/docroot/themes/bootstrap/templates/system/page.html.twig
    @@ -0,0 +1,152 @@
    +      {%  endif %}
    

    Extra space before the endif.

  21. +++ b/docroot/themes/bootstrap/templates/system/page.html.twig
    @@ -0,0 +1,152 @@
    +      </aside>  <!-- /#sidebar-first -->
    

    This comment is not correct.

  22. +++ b/docroot/themes/bootstrap/templates/system/page.html.twig
    @@ -0,0 +1,152 @@
    +      </aside> <!-- /#sidebar-second -->
    

    This comment is not correct.

  23. +++ b/docroot/themes/bootstrap/templates/system/region.vars.php
    @@ -4,14 +4,16 @@
    +//  $variables['attributes'] = new Attribute();
    

    More commented-out code.

  24. +++ b/docroot/themes/bootstrap/templates/system/select.vars.php
    @@ -0,0 +1,20 @@
    +$element = $variables['element'];
    

    Needs to be indented.

neardark’s picture

neardark’s picture

neardark’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: update_registry_to_work-2393767-4.patch, failed testing.

neardark’s picture

neardark’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: update_registry_to_work-2393767-6.patch, failed testing.

neardark’s picture

neardark’s picture

Status: Needs work » Needs review
neardark’s picture

neardark’s picture

FileSize
132.18 KB
gregnostic’s picture

Status: Needs review » Reviewed & tested by the community

  • neardark committed ecd792a on 8.x-3.x
    Issue #2393767 by neardark: Update registry to work with D8
    

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: update_registry_to_work-2393767-7.patch, failed testing.

markhalliwell’s picture

Committed #2098551: Registry alter does not keep proper order of [pre]process functions to the 8.x branch. Not sure if this issue is still CNW or not, so I'm not going to touch the status.

markhalliwell’s picture

Status: Needs work » Closed (duplicate)
Related issues: +#2247445: Refactor Theme Registry