The comment form_id in the settings form don't work anymore.
Seems the form id is the same for all comment form.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bès’s picture

Here is a small fix tested on node entity only for now.

Maybe a better one should be to check all the comment bundle in the settings form since the form_id of a entity form is based on that EntityForm::getFormId()

geerlingguy’s picture

Status: Active » Needs work

I'll try to get to this soon; I think it may be best to find a way to test on more than one comment form, too, just so we can make sure bugs like this don't slip past the testbot in the future.

geerlingguy’s picture

Status: Needs work » Needs review

I'll go ahead and give the testbot a workout.

It looks like we'll have to run through 'comment' types and give a checkbox for each comment type form, rather than node/entity types. I'd like to add an automated test that adds an additional comment type and tests with both the standard 'comment' comment type and an additional one.

I just did a little testing, and the default comments form is comments_comment_form, and if I add a new 'Ratings' comment type, that form's ID becomes ratings_comment_form. So, confirmed that I'll need to loop through comment types rather than content types.

geerlingguy’s picture

Assigned: Unassigned » geerlingguy
FileSize
2.64 KB

Updated patch attached; this loads all comment form types and lists them as individual checkboxes.

geerlingguy’s picture

This time without the debug code.

  • geerlingguy committed b7bef98 on 8.x-1.x
    Issue #2392507 by geerlingguy, Bès: Honeypot not working on comment
    

Status: Needs review » Needs work

The last submitted patch, 5: honeypot-comments-2392507-5.patch, failed testing.

geerlingguy’s picture

So I committed some of the work (getting the comment forms working), but now there's a new bug that doesn't allow inlining CSS (see #2391025: Add support for inline JS/CSS with #attached), so I'll open a new bug report for that.

geerlingguy’s picture

Status: Needs work » Fixed

The last submitted patch, 1: add-honeypot-comment-2392507-1.patch, failed testing.

The last submitted patch, 4: honeypot-comments-2392507-4.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.