For LibrariesUnitTest the extended class Drupal\simpletest\DrupalUnitTestBase no longer exists as per this change notice https://www.drupal.org/node/2271271 and the Dec 5th commit in #2388043: Remove DrupalUnitTestBase. This not only causes the Libraries API test to fail but it also causes a fatal error when loading the test list in the UI or when running any tests for modules that depend on Libraries API (e.g. with d.o. testbots, etc.). Marking an major since this has ramifications on the ability to load any tests, not just tests from this module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rjacobs’s picture

Status: Active » Needs review
FileSize
535 bytes

Here's a patch with a simple name change for the class used.

I don't think tests will pass however, as it looks like there are other test issues with some functional tests (unrelated to this issue). Meh, let's see what the testbots do.

rjacobs’s picture

Yep, test status "postponed". Anyway, I hope someone will still be able to have a look at this as I don't think the other test issues should hold this up if at all possible.

yukare’s picture

Status: Needs review » Reviewed & tested by the community

We need this commited before working on other errors in tests. This make impossible to run the tests for ANY module that depends on libraries.

This patch fixes the fatal error, the others error are related to other issues, like the removal of url().

rjacobs’s picture

Issue summary: View changes

Updated the summary based on the previous comment. Though I can apply this patch to get tests working on my dev space I see now that it's currently impossible to run any of my tests on d.o.

tstoeckler’s picture

Status: Reviewed & tested by the community » Fixed

Awesome, thanks a lot.
Committed to 8.x-3.x

  • tstoeckler committed 04e6d12 on 8.x-3.x authored by rjacobs
    Issue #2390301 by rjacobs: Fix DrupalUnitTestBase no longer exists so...

Status: Fixed » Needs work

The last submitted patch, 1: libraries-drupalunittestbase_removed-2390301-1.patch, failed testing.

rjacobs’s picture

Status: Needs work » Fixed

Thanks!

I think the system applied status change (to "needs work") was because the testbots were trying to test the patch against a repo snapshot that already contained the patch. I believe its safe to re-apply the "fixed" status.

To confirm, my own tests that depend on Libraries API are no longer failing because of this issue. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.