Hey guys,

thank you for this awesome module.

I have a little issue with it anyway. I want my users to log in and get back to the page they came from or did not have access to in the first place.
So I would like the Simple FB Connect module to use the $_GET['destination'] value.

I created a patch for this which will be uploaded to here as soon as it is tested internally.

Please, be aware that to make this patch work, the url to the Facebook login page (user/simple-fb-connect) needs to be appended by the destination parameter which would create for example an url like this: http://example.com/user/simple-fb-connect?destination=node/add/page

Patch will be in the first comment ASAP.

Thank you for your time.

fun0c0der

CommentFileSizeAuthor
#4 simple_fb_connect-redirect_to_destination_after_login-2389747-1.patch1.89 KBfunc0der
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

masipila’s picture

masipila CreditAttribution: masipila commented

I would recommend that you would write the patch against the 2.x branch.

For further discussion about the branches, see #2386041: Documentation is needed about difference between 1.x or 2.x branch

Cheers,
Markus

func0der’s picture

func0der CreditAttribution: func0der commented

Can do that, as soon as I find the time to.

Should be merged in 1.x anyway since it seems as 2.x is not going to be stable anytime soon.

tzin111@gmail.com’s picture

tzin111@gmail.com CreditAttribution: tzin111@gmail.com commented

i also have the same problem with this module.
can you explane how to solve ?

func0der’s picture

func0der CreditAttribution: func0der commented
FileSize
simple_fb_connect-redirect_to_destination_after_login-2389747-1.patch1.89 KB

I just realized that I have not uploaded the patch yet.

Sorry for that. Here it is.

The comment number in the file name is wrong, but I think that should no be that problematic now.

  • masipila committed 5f3c748 on 7.x-2.x 
    Issue #2389747 by masipila: Redirect to ['destination'] if given
masipila’s picture

masipila CreditAttribution: masipila commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Active » Fixed

This is now fixed to 7.x-2.x branch which will soon see a beta release. Further instructions can be found from the README file.

Note that 7.x-2.x is using Facebook PHP SDK v4 instead of v3.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.