Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#20 | node-admin-2389333-test-coverage-20.patch | 4.33 KB | SwapS |
| |||
#17 | node-admin-2389333-test-coverage-17.patch | 4.3 KB | saurabh-chugh |
#14 | node-admin-2389333-test-coverage-14.patch | 4.28 KB | SwapS |
#9 | node-admin-2389333-diff-7-9.txt | 949 bytes | vijaycs85 |
#9 | node-admin-2389333-test-coverage-9.patch | 5.09 KB | vijaycs85 |
Comments
Comment #1
pacproduct CreditAttribution: pacproduct commentedComment #2
vijaycs85Initial patch...
Comment #4
vijaycs85Wrong version...
Comment #6
pacproduct CreditAttribution: pacproduct commentedMy review comments below.
(minor) Period missing.
(minor) Period missing.
(minor) Unnecessary blank line.
(minor) Capital letter for "or" maybe?
(minor) Period missing.
I would have put the blank line after $this->drupalLogin() instead.
Or none at all here.
(minor) Period missing.
(minor) Should be "its".
Typo: Should be "assert".
Is that empty line needed (applies to other functions as well)?
(minor) Unnecessary blank line.
Typo: Should be "assert".
Comment doesn't match what is being tested.
(minor) Unnecessary blank line.
Comment #7
vijaycs85thanks for the review @pacproduct. Here is an update for all items in #6
Comment #8
pacproduct CreditAttribution: pacproduct commentedLooks okay to me.
Comment #9
vijaycs85Few more empty line fixes.
Comment #10
pacproduct CreditAttribution: pacproduct commentedComment #12
vijaycs85Comment #13
vijaycs85Let's port to D7
Comment #14
SwapS CreditAttribution: SwapS as a volunteer and at Tech Mahindra commentedMachi ,
Attached is the patch for D7 port
Cheers
SwapS
Comment #15
SwapS CreditAttribution: SwapS as a volunteer and at Tech Mahindra commentedComment #17
saurabh-chugh CreditAttribution: saurabh-chugh as a volunteer and at TATA Consultancy Services commentedHey
Looks like one of the required permission is missing.
Re-attaching updated patch
Saurabh Chugh
Comment #18
saurabh-chugh CreditAttribution: saurabh-chugh as a volunteer and at TATA Consultancy Services commentedComment #20
SwapS CreditAttribution: SwapS as a volunteer and at Tech Mahindra commentedOne more update ..
This should pass test run
Cheers
SwapS
Comment #21
saurabh-chugh CreditAttribution: saurabh-chugh as a volunteer and at TATA Consultancy Services commentedComment #23
vijaycs85Thank you!
Comment #24
vijaycs85