testGetBaseTable is supposed to test that the storage falls back to the entity type ID. It does not because it hardcodes the base table as a return value.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because missing test coverage
Unfrozen changes Unfrozen because it only fixes a test
CommentFileSizeAuthor
drupal8.SqlContentEntityStorageTest.patch657 bytesalexpott

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Nice catch :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal8.SqlContentEntityStorageTest.patch, failed testing.

Status: Needs work » Needs review

plach queued drupal8.SqlContentEntityStorageTest.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal8.SqlContentEntityStorageTest.patch, failed testing.

Status: Needs work » Needs review

adci_contributor queued drupal8.SqlContentEntityStorageTest.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

re-rtbc

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 6cf1d80 on 8.0.x 
    Issue #2388125 by alexpott: testGetBaseTable is supposed to test that...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.