[D7] Summary Teaser [#2387589]

https://www.drupal.org/sandbox/joshmelbs/2387587

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/joshmelbs/2387587.git 
summary_teaser
cd summary_teaser

Adds 2 new body field formats:

"Summary and body" displays summary followed by body - useful for full page view mode.

"Expandable body" displays summary with toggle for body - useful for teaser view mode.

Helps editors avoid duplication of content between the summary and body fields.

Includes an admin option for toggle to call body content via ajax.

Comments

Comment #1

prdctvtxt CreditAttribution: prdctvtxt commented 5 December 2014 at 04:15

Status:

Needs review

» Needs work

Automated Review

FILE: /var/www/drupal-7-pareview/pareview_temp/js/summary_teaser.js
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [ ] Missing file doc comment
8 | ERROR | [x] Inline control structures are not allowed
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/css/summary_teaser.css
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
3 | ERROR | [ ] Line indented incorrectly; expected 2 spaces, found 1
24 | ERROR | [x] Additional whitespace found at end of file
25 | ERROR | [ ] Files must end in a single new line character
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/summary_teaser.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
5 | ERROR | There must be exactly one blank line after the file comment
6 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/summary_teaser.module
--------------------------------------------------------------------------------
FOUND 45 ERRORS AND 6 WARNINGS AFFECTING 38 LINES
--------------------------------------------------------------------------------
8 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
8 | ERROR | [ ] Doc comment short description must end with a full stop
37 | ERROR | [ ] Doc comment short description must end with a full stop
50 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
50 | ERROR | [ ] Doc comment short description must end with a full stop
67 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
67 | ERROR | [ ] Doc comment short description must end with a full stop
87 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
87 | ERROR | [ ] Doc comment short description must end with a full stop
100 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", or "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
100 | ERROR | [ ] Doc comment short description must end with a full stop
122 | ERROR | [ ] Inline comments must start with a capital letter
122 | ERROR | [ ] Inline comments must end in full-stops, exclamation marks,
| | or question marks
124 | ERROR | [ ] Expected "if (...) {\n"; found "if(...) {\n"
129 | ERROR | [ ] Inline comments must start with a capital letter
129 | ERROR | [ ] Inline comments must end in full-stops, exclamation marks,
| | or question marks
132 | ERROR | [ ] else must start on a new line
135 | ERROR | [ ] Inline comments must start with a capital letter
135 | ERROR | [ ] Inline comments must end in full-stops, exclamation marks,
| | or question marks
137 | ERROR | [ ] Expected "if (...) {\n"; found "if(...) {\n"
142 | ERROR | [ ] Inline comments must start with a capital letter
142 | ERROR | [ ] Inline comments must end in full-stops, exclamation marks,
| | or question marks
148 | ERROR | [ ] Case breaking statements must be followed by a single
| | blank line
148 | ERROR | [ ] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
152 | ERROR | [ ] Expected "if (...) {\n"; found "if(...) {\n"
163 | ERROR | [ ] Case breaking statement indented incorrectly; expected 6
| | spaces, found 4
168 | ERROR | [ ] Missing short description in doc comment
170 | ERROR | [ ] Missing parameter type
173 | ERROR | [ ] Missing parameter type
176 | ERROR | [ ] Missing parameter type
179 | ERROR | [ ] Return type missing for @return tag in function comment
180 | ERROR | [ ] Return comment indentation must be 3 spaces, found 2
| | spaces
185 | ERROR | [ ] Expected "if (...) {\n"; found "if(...) {\n"
216 | ERROR | [ ] Missing short description in doc comment
218 | ERROR | [ ] Missing parameter type
219 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
221 | ERROR | [ ] Missing parameter type
224 | ERROR | [ ] Missing parameter type
227 | ERROR | [ ] Return type missing for @return tag in function comment
230 | ERROR | [ ] Arguments with default values must be at the end of the
| | argument list
233 | ERROR | [x] Expected 1 space before "=>"; 0 found
233 | ERROR | [x] Expected 1 space after "=>"; 0 found
233 | ERROR | [x] Expected 1 space before "=>"; 0 found
233 | ERROR | [x] Expected 1 space after "=>"; 0 found
253 | ERROR | [ ] Missing short description in doc comment
255 | ERROR | [ ] Missing parameter type
258 | ERROR | [ ] Missing parameter type
261 | ERROR | [ ] Return type missing for @return tag in function comment
274 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
275 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
278 | ERROR | [ ] Files must end in a single new line character
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Comment #2

prdctvtxt CreditAttribution: prdctvtxt commented 5 December 2014 at 04:31

Issue summary:

View changes

Comment #3

joshbotnet CreditAttribution: joshbotnet commented 6 December 2014 at 02:39

Status:

Needs work

» Needs review

Thanks for the initial review prdctvtxt.

All issues resolved - http://pareview.sh/pareview/httpgitdrupalorgsandboxjoshmelbs2387587git

Please review and approve as a full project.

Comment #4

joshbotnet CreditAttribution: joshbotnet commented 6 December 2014 at 02:41

Issue summary:

View changes

Comment #5

PA robot CreditAttribution: PA robot commented 6 December 2014 at 05:23

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #6

prdctvtxt CreditAttribution: prdctvtxt commented 9 December 2014 at 01:03

Assigned:

Unassigned

» prdctvtxt

Assigning to me for manual review.

Comment #7

prdctvtxt CreditAttribution: prdctvtxt commented 9 December 2014 at 01:39

Assigned:	prdctvtxt	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

Manual review passes, the module installs and functions as described. Nice one!

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts.
No duplication: Yes: Does not cause module duplication and/or fragmentation.
Master Branch: Yes: Follows the guidelines for master branch.
Licensing: Yes: Follows the licensing requirements.
3rd party assets/code: Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md: Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review: Yes: Follows the guidelines for project length and complexity.
Secure code: Yes: Meets the security requirements.

Comment #8

kscheirer

English

Vallejo

CreditAttribution: kscheirer commented 20 February 2015 at 04:34

Status:

Reviewed & tested by the community

» Fixed

Non-blocking issues:

Your README has a typo, there's a space missing in "usefulfor"
You should remove all variables like summary_teaser_ajax in a hook_uninstall()

Thanks for your contribution, joshmelbs!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.