On an OpenFed 7.x-1.9 I enabled the language_selection_page module. After navigating from the language selection page I get the following warnings:

Strict warning: Only variables should be passed by reference in language_selection_page_request_path() (line 222 of DRUPALROOT\profiles\openfed\modules\contrib\language_selection_page\language_selection_page.module).
Notice: Undefined index: attributes in theme_image() (line 1785 of /DRUPALROOT/includes/theme.inc).

Receiving warnings on both:

Web Server: Apache/2.4.7 (Ubuntu)
PHP 5.5.9

&
Web Server: Apache/2.4.10 (Win32) OpenSSL/1.0.1i PHP/5.6.3
PHP 5.6.3

I also get the first warning when proceeding Setup regional installation process step after ticking the "Language cookie and language selection page" checkbox. (see attached file)

CommentFileSizeAuthor
installprofile-setup-taxonomy.PNG30.54 KBbaikho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bart.hanssens’s picture

bart.hanssens CreditAttribution: bart.hanssens commented
Issue tags: +php5.5

Thanks for reporting this issue. It could be a PHP5.5 / 5.6-only error, currently we only test on PHP5.4

Gleach’s picture

Gleach CreditAttribution: Gleach commented

Subscribed

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Project: OpenFed » Language Selection Page
Version: 7.x-1.9 » 7.x-2.x-dev
stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Title: Strict warnings after navigating from the language selection page » Module upgrade: Language Selection Page
Project: Language Selection Page » OpenFed
Version: 7.x-2.x-dev » 7.x-1.x-dev

This has already been fixed in #2332059: PHP error: Only variables can be passed by reference. This would be fixed by upgrading to beta3.

bart.hanssens’s picture

bart.hanssens CreditAttribution: bart.hanssens commented
Assigned: Unassigned » bart.hanssens
Status: Active » Fixed
Related issues: +#2429853: Module upgrade: Language Selection Page

Should be fixed in 1.10-beta2

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: -php5.5 +PHP 5.5

using the more common tag (so I can delete the less commonly used one)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rutiolma’s picture

rutiolma
Location 🇵🇹
CreditAttribution: rutiolma commented
Status: Closed (fixed) » Active

This issue was fixed with the commit #d9a3281 but commit #7b83a06 brought it back with the downgrade to Language Selection Page 2.0-beta2

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Issue tags: +openfed2.0

This fix never made it into an actual release (nor did any of the upgrades in #d9a3281), they were postponed to 2.0 or later.

Tagging this for inclusion back into 2.0

bdeclerc’s picture

bdeclerc CreditAttribution: bdeclerc commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Assigned: bart.hanssens » stefan.r

Let's include this in openfed2.0

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Active » Closed (duplicate)

added

michal.k’s picture

michal.k CreditAttribution: michal.k commented

I noticed this issue on my openfed 7.x-2.4 instance.

michal.k’s picture

michal.k CreditAttribution: michal.k commented

I had this notice:
Notice: Undefined index: attributes in theme_image() (line 1785 of /DRUPALROOT/includes/theme.inc)
It was because of missing argument in ofed_theme_nerra in html--language-selection.tpl.php line 93
print theme_image(array('path' => $logo, 'alt' => 'Logo', 'title' => 'Logo'));
should be replaced by:
print theme_image(array('path' => $logo, 'alt' => 'Logo', 'title' => 'Logo', 'attributes' => array()));