Compile for FireCompass instead of FireSass [#2385301]

Not sure if issue https://www.drupal.org/node/2362503 is related and will solve this.

Currently config.rb compiles CSS for the FireSass plugin, but it is gone and FireCompass is here instead.

Comment	File	Size	Author
	adaptivetheme-use_firecompass.patch	1.34 KB	xenophyle

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

xenophyle CreditAttribution: xenophyle commented 1 December 2014 at 21:18

Status:

Active

» Needs review

Comment #2

Jeff Burnz CreditAttribution: Jeff Burnz commented 2 December 2014 at 22:08

Hmm, those config.rb files look a bit unloved, the one in core and the generator.

What do you prefer - FireCompass, honestly I could never get it to work and in all the other config.rb I now spec sourcemaps and line comments, so I would think that if you are having joy with FireCompass (I have not had any joy), then by rights it should just work.

I'm more than happy to remove FireSass since it blows away line comments and ruins my buzz, and while I dearly love working with Firebug I tend to use the inspector more and more and Chrome tools most of all.

Which all basically means we can clean up these core config files since I have let them get a big rough and not really taken much notice of them at this stage :(

This is what the UIKit config rb looks like (well, this bit of it):

# Line Comments
# --------------------------------------------------------------------------
line_comments = (environment == :development) ? true : false


# Sourcemaps
# --------------------------------------------------------------------------
sourcemap = (environment == :development) ? true : false

Comment #3

xenophyle CreditAttribution: xenophyle commented 3 December 2014 at 19:43

I remained silent on sourcemaps since we just updated sass and I haven't tested it yet, but it should be included, in my barely-educated opinion. FireCompass started working for me once I included the line_comments setting.

Comment #4

Jeff Burnz CreditAttribution: Jeff Burnz commented 3 December 2014 at 22:40

Oh thats great you have FireCompass working. I'll update the config files to include source maps and line comments and remove FireSass entirely. This brings it into line wit the other config rb files in the system.

Thanks for alerting me about FireCompass, I had actually forgotten all about it since I use soucemaps all the time now.

Comment #5

Jeff Burnz CreditAttribution: Jeff Burnz commented 3 December 2014 at 23:55

Status:

Needs review

» Active

OK, I fired an update that cleans this all up:

- removed old FireSass stuff
- add sourcemaps
- add grunt
- add GEM file (ops forgot to bundle update so the lock file will be wrong, will update shortly).
- add csslintrc to adaptivetheme root so both at_core and the generator can lint their CSS off the same configuration

So this is all now in line with the UIKit/Subthemes and we have a much better system in place for dev of the core themes.

Phew.

I'll leave this as active until I update the gem file locks.