Force unprocessed uploads to temporary:// [#2383527]

Comment	File	Size	Author
#1	use_temporary-2383527-1.patch	1.33 KB	Deciphered

File	Size
use_temporary-2383527-1.patch	1.33 KB

Comment #2

Deciphered CreditAttribution: Deciphered commented 19 August 2015 at 22:32

Status:

Needs review

» Needs work

Unfortunately it appears that Image styles don't get applied to files in the temporary file system, which is a pretty big issue for this. Will need to investigate further.

Log in or register to post comments

Comment #3

Deciphered CreditAttribution: Deciphered commented 30 August 2015 at 22:35

Issue with temporary:// Image styles reported: #2560139: Image styles in 'temporary://' not generated.

Log in or register to post comments

Comment #4

Deciphered CreditAttribution: Deciphered at Realityloop for Media Insights commented 30 August 2015 at 22:37

Status:

Needs work

» Fixed

Committed with workaround for image style issue.

Log in or register to post comments

Comment #6

JordanMagnuson CreditAttribution: JordanMagnuson commented 7 September 2015 at 21:36

Status:

Fixed

» Needs work

This specific commit causes Filefield Paths to stop working nicely with Filefield Sources for me... now when I try to save a node after uploading a file via filefield sources plupload (the initial upload works fine), I'm getting this error:

The specified file temporary://plupload_test_2mb_d.zip could not be copied, because no file by that name exists. Please check that you supplied the correct filename.

See screenshot: http://i.imgur.com/rWMpbrF.png

When I revert this commit, everything works fine...

Log in or register to post comments

Comment #7

Deciphered CreditAttribution: Deciphered at Realityloop for Media Insights commented 7 September 2015 at 23:43

So while File (Field) Paths did introduce this issue by doing something out of the ordinary, the issue isn't necessarily with File (Field) Paths.

The issue is that temporary location and the upload destination is the same, and the FileField Sources Plupload module isn't checking if that is the case, and just deleting the temporary location file, which is the real file.

Given that this is an issue in the Plupload source and the Remote source I will implement a workaround, which is to upload the file to a subdirectory in the temporary file system, but I will also be opening issues in the relevant modules as they really should be checking before they delete the file.

Log in or register to post comments

Comment #8

Deciphered CreditAttribution: Deciphered at Realityloop for Media Insights commented 8 September 2015 at 00:10

#2564593: Check temporary file isn't destination file before deleting.
#2564597: Check temporary file isn't destination file before deleting.

Take into account that while there is a patch for FileField Sources Plupload, that integration still doesn't work with File (Field) Paths anyway due to another issue (#1854450: Support for Media).

Workaround for File (Field) Paths will come later.

Log in or register to post comments

Comment #9

JordanMagnuson CreditAttribution: JordanMagnuson commented 9 September 2015 at 17:04

Thanks Deciphered! Applied those patches, and everything is working great.

I'm confused when you say that FileField Sources Plupload won't work properly because of the Support for Media issue... are these issues even related? FileField Sources Plupload seems to be working fine at the moment with Filefield Paths with the patch you provided (though currently I'm only using the plupload sources widget to upload single value file fields -- ie not fields that allow multiple files -- if that makes any difference).

Log in or register to post comments

Comment #10

Deciphered CreditAttribution: Deciphered at Realityloop for Media Insights commented 9 September 2015 at 19:55

I didn't work for me for the same reason that the "Media" issue doesn't work, which is the file doesn't have the appropriate flag allowing the file to be processed. If it work for you, that's great.

I still intend to look further into the issue.