I'm trying to get this to work with the Salesforce Mappings module.
It generates URLs for every mapped entity to provide a UI for checking an entities pushes and pulls to salesforce.
It assumes each entity has a load function: ENTITY_load(), like node_load(), user_load() etc.
This is pretty much a standard practice around drupal. Problem is, there is no webform_submission_entity_load() function.
So after looking into it, I noticed you weren't too happy with the name of the load function you had:
/**
*
* Note this function could not be called webform_entity_webform_submission_load()
* because that would be a namespace colision. Can't wait for PHP 5.3 to be
* everywhere.
*
* @param $sid
* The sid of a sigle webform submission entity to load.
*/
function webform_entity_load_webform_submission($sid) {
So I propose changing that to webform_submission_entity_load() to maintain consistency with Drupal's other entities.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2382791-webform_submission_entity_load-2.patch | 2.23 KB | Jon Pugh |
Comments
Comment #1
Jon PughComment #2
Jon Pughrerolling
Comment #3
AaronBaumanPatch #2 works as advertised.
You will probably also want to implement salesforce_mapping_entity_uris_alter() per #2382791: Change function webform_entity_load_webform_submission($sid) to webform_submission_entity_load($sid):
Comment #5
AaronBaumancommitted