entity_translation_update_7006 fails because of SQL error before variable_set('entity_translation_revision_enabled', FALSE); can run - even trying to use drush vset fails. The problem appears to be here:

./includes/translation.handler.inc:905:    return variable_get('entity_translation_revision_enabled', TRUE) && !empty($entity_info['entity keys']['revision']);

Shouldn't we default that to FALSE? Otherwise, instant fatal before it can even run the update. Default it to false, then enable it at the end of the update (as well as in the install hook for new installs).

The only way I could get the update to run without this change was to directly insert the variable into the database.

CommentFileSizeAuthor
#1 revision_enabled-2382713-1.patch1.9 KBseanr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seanr’s picture

Status: Active » Needs review
FileSize
1.9 KB

Patch attached.

seanr’s picture

Issue summary: View changes
andros’s picture

I have had the problem on one site after updating to latest dev, 7.x-1.0-beta3+15-dev (2014-Nov-22) that it said „entity_translation_revision' doesn't exist“ The only thing I get was a server error 500.
On an another site the same error showed up some times in the protocol but vanished by it self!?

  • seanr authored c89c110 on 7.x-1.x
    Issue #2382713 by seanr: entity_translation_update_7006 fails because of...
plach’s picture

Status: Needs review » Fixed

Actually I preferred not to need the variable to be set on new installations, but it seems this fix is badly needed.

Committed #1 and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

plach’s picture