When creating a new translation for an entity, the code only ports default values:
- for the 1st item (default values can be multi-items)
- for the 'value' property (the set of properties depend on the field type)

CommentFileSizeAuthor
#13 interdiff.txt1.11 KByched
#13 2382493-translation_default_values-13.patch9.43 KByched
#10 2382493-translation_default_values-10.patch9.91 KByched
#10 2382493-translation_default_values-10-fix-only.patch556 bytesyched
#10 2382493-translation_default_values-10-test-only.patch9.37 KByched
#8 interdiff.txt1.38 KByched
#8 2382493-translation_default_values-8.patch9.91 KByched
#4 2382493-translation_default_values-5.patch8.54 KByched
#4 2382493-translation_default_values-5-test-only.patch7.99 KByched
#2 2382493-translation_default_values-not-for-review-3.patch558 bytesyched
#1 2382493-translation_default_values-1.patch556 bytesyched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2382493-translation_default_values-1.patch556 bytes

Patch - needs tests, but not sure where they should be added yet.

yched’s picture

yched CreditAttribution: yched commented
FileSize
2382493-translation_default_values-not-for-review-3.patch558 bytes

This is a smoketest patch that just removes the behavior, in the hope that the failing tests will point me to which test curently test this :-)

Status: Needs review » Needs work

The last submitted patch, 2: 2382493-translation_default_values-not-for-review-3.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
FileSize
2382493-translation_default_values-5-test-only.patch7.99 KB
2382493-translation_default_values-5.patch8.54 KB

With tests.

To test the fact that we don't hardcode logic on the 'value' property, this switches the existing entity_test_field_default_value() callback, targetting it for the "shape" test field type.

The existing EntityTestDefaultValue, that also uses that callback, is changed accordingly - this also tests that "multiple items" default values work as expected, which was apparently not tested so far.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review

The last submitted patch, 4: 2382493-translation_default_values-5-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2382493-translation_default_values-5.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Issue tags: -Needs tests
FileSize
2382493-translation_default_values-8.patch9.91 KB
interdiff.txt1.38 KB

Hm - that means moving the ShapeItem field type over to entity_test, though.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
yched’s picture

yched CreditAttribution: yched commented
FileSize
2382493-translation_default_values-10-test-only.patch9.37 KB
2382493-translation_default_values-10-fix-only.patch556 bytes
2382493-translation_default_values-10.patch9.91 KB

Now that we're green, reuploading patch & test-only patch.
Note that the actual fix (see fix-only.patch) is a one liner, the rest is about making this testable.

The last submitted patch, 10: 2382493-translation_default_values-10-test-only.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented 
+++ b/core/modules/system/src/Tests/Entity/EntityTranslationTest.php
@@ -16,7 +16,9 @@
+  class EntityTranslationTest extends EntityLanguageTestBase {

Looks good, I have found just this wrong indentation :)

yched’s picture

yched CreditAttribution: yched commented
FileSize
2382493-translation_default_values-13.patch9.43 KB
interdiff.txt1.11 KB

Oops, indeed.
Also, reverted the addition of field_test.module to EntityFieldDefaultValueTest / EntityTranslationTest, not needed anymore.

yched’s picture

yched CreditAttribution: yched commented

RTBC anyone ?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Reviewed & tested by the community

Me :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 1290d38 and pushed to 8.0.x. Thanks!

  • alexpott committed 1290d38 on 8.0.x 
    Issue #2382493 by yched: Population of default field values in entity...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.