Apparently the region and pane HTML output in the panel editor view is not using theme layer. By using theme function we'd be able to override the output for easily making changes for the class attributes and such. Wasn't sure whether to put the theme functions into the class file, but that's what I felt was the right place to have it in the end.

Here's the patch to be reviewed.

CommentFileSizeAuthor
#3 panels-use-theme-for-admin-panel-region-pane-output-2382479-3.patch5.39 KBTomiMikola
#2 panels-use-theme-for-admin-panel-region-pane-output-2382479-2.patch5.15 KBTomiMikola
#1 panels-use-theme-for-admin-panel-region-pane-output-2382479.patch5.15 KBTomiMikola
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TomiMikola’s picture

TomiMikola CreditAttribution: TomiMikola commented
Issue summary: View changes
Status: Active » Needs review
FileSize
panels-use-theme-for-admin-panel-region-pane-output-2382479.patch5.15 KB
TomiMikola’s picture

TomiMikola CreditAttribution: TomiMikola commented
FileSize
panels-use-theme-for-admin-panel-region-pane-output-2382479-2.patch5.15 KB

Fix a typo in variable names. Patch updated.

TomiMikola’s picture

TomiMikola CreditAttribution: TomiMikola commented
FileSize
panels-use-theme-for-admin-panel-region-pane-output-2382479-3.patch5.39 KB

Adding #panels_renderer and #pane for the theme functions to ease retrieving metadata in the preprocess hooks. Patch updated.

robmcbryde queued 3: panels-use-theme-for-admin-panel-region-pane-output-2382479-3.patch for re-testing.