Ensure module works with i18n_taxonomy

Hi Damien!

Thank you for quick response, but the patch not resolves the problem

metatags (Array, 1 element)
  und (Array, 1 element)
    title (Array, 1 element)
      value (String, 31 characters ) [term:name] | [site:name] | ccc

The value contains the string what I typed during the previous edit, and this value is saved in db. But when I reopen term to edit, the default value of Title input is: "[term:name] | [site:name]"

This value was added here: admin/config/search/metatags/config/taxonomy_term

I updated the metatag module to latest dev ( version: 7.x-1.4+21-dev ), but the updating still does not solve the problem

Here is my list of enabled modules ( the output of drush pm-list --type=module --status=enabled ):
Package Name Version
Access control Taxonomy Access Control Lite (tac_lite) 7.x-1.2+1-dev
Administration Administration menu (admin_menu) 7.x-3.0-rc4+4-
dev
Administration Administration menu Toolbar style 7.x-3.0-rc4+4-
(admin_menu_toolbar) dev
Administration Administration views (admin_views) 7.x-1.3
Administration Module filter (module_filter) 7.x-2.0-alpha2
Chaos tool suite Chaos tools (ctools) 7.x-1.4+9-dev
Chaos tool suite Custom content panes (ctools_custom_content) 7.x-1.4+9-dev
Chaos tool suite Page manager (page_manager) 7.x-1.4+9-dev
Chaos tool suite Views content panes (views_content) 7.x-1.4+9-dev
Clientside Clientside Validation 7.x-1.41
Validation (clientside_validation)
Clientside Clientside Validation Form 7.x-1.41
Validation (clientside_validation_form)
Commerce Cart (commerce_cart) 7.x-1.10
Commerce Checkout (commerce_checkout) 7.x-1.10
Commerce Commerce (commerce) 7.x-1.10
Commerce Commerce Billy (commerce_billy) 7.x-1.0-beta2
Commerce Commerce Billy PDF (commerce_billy_pdf) 7.x-1.0-beta2
Commerce Commerce UI (commerce_ui) 7.x-1.10
Commerce Customer (commerce_customer) 7.x-1.10
Commerce Customer UI (commerce_customer_ui) 7.x-1.10
Commerce Line Item (commerce_line_item) 7.x-1.10
Commerce Line Item UI (commerce_line_item_ui) 7.x-1.10
Commerce Order (commerce_order) 7.x-1.10
Commerce Order UI (commerce_order_ui) 7.x-1.10
Commerce Payment (commerce_payment) 7.x-1.10
Commerce Payment UI (commerce_payment_ui) 7.x-1.10
Commerce Price (commerce_price) 7.x-1.10
Commerce Product (commerce_product) 7.x-1.10
Commerce Product Pricing (commerce_product_pricing) 7.x-1.10
Commerce Product Pricing UI 7.x-1.10
(commerce_product_pricing_ui)
Commerce Product Reference 7.x-1.10
(commerce_product_reference)
Commerce Product UI (commerce_product_ui) 7.x-1.10
Commerce Commerce Addressbook (commerce_addressbook) 7.x-2.0-rc8
(contrib)
Commerce Commerce Billy Mail (commerce_billy_mail) 7.x-1.0-beta3
(contrib)
Core Block (block) 7.34
Core Color (color) 7.34
Core Comment (comment) 7.34
Core Content translation (translation) 7.34
Core Contextual links (contextual) 7.34
Core Dashboard (dashboard) 7.34
Core Database logging (dblog) 7.34
Core Field (field) 7.34
Core Field SQL storage (field_sql_storage) 7.34
Core Field UI (field_ui) 7.34
Core File (file) 7.34
Core Filter (filter) 7.34
Core Help (help) 7.34
Core Image (image) 7.34
Core List (list) 7.34
Core Locale (locale) 7.34
Core Menu (menu) 7.34
Core Node (node) 7.34
Core Number (number) 7.34
Core Options (options) 7.34
Core Overlay (overlay) 7.34
Core Path (path) 7.34
Core RDF (rdf) 7.34
Core Shortcut (shortcut) 7.34
Core System (system) 7.34
Core Taxonomy (taxonomy) 7.34
Core Text (text) 7.34
Core Trigger (trigger) 7.34
Core Update manager (update) 7.34
Core User (user) 7.34
Date/Time Date (date) 7.x-2.8
Date/Time Date API (date_api) 7.x-2.8
Development Devel (devel) 7.x-1.5
Display Suite Display Suite (ds) 7.x-2.7
Display Suite Display Suite UI (ds_ui) 7.x-2.7
Entityforms Entityforms (entityform) 7.x-2.0-rc1
FAQ faq_content (faq_content) 7.x-2.0-alpha2
FAQ faq_expert (faq_expert) 7.x-2.0-alpha2
FAQ Frequently Asked Questions (faq) 7.x-2.0-alpha2
Features Features (features) 7.x-2.2
Features Features Diff (features_diff) 7.x-1.0-beta1
Fields Address Field (addressfield) 7.x-1.0-beta5
Fields Email (email) 7.x-1.3
Fields Field Permissions (field_permissions) 7.x-1.0-beta2
Fields File Field Sources (filefield_sources) 7.x-1.9
Fields Telephone (telephone) 7.x-1.0-alpha1
Fields Title (title) 7.x-1.0-alpha7
+10-dev
Flags Flag (flag) 7.x-3.5
FlexSlider FlexSlider (flexslider) 7.x-2.0-alpha3
FlexSlider FlexSlider Views Style (flexslider_views) 7.x-2.0-alpha3
Form Elements Hierarchical Select (hierarchical_select) 7.x-3.0-alpha6
Form Elements Hierarchical Select Taxonomy (hs_taxonomy) 7.x-3.0-alpha6
Input filters Pathologic (pathologic) 7.x-3.0-beta2
Input filters SpamSpan (spamspan) 7.x-1.1-beta7
Mail Mail System (mailsystem) 7.x-2.34
Mail Mime Mail (mimemail) 7.x-1.0-beta3+
13-dev
Mail Mime Mail Action (mimemail_action) 7.x-1.0-beta3+
13-dev
Mail Mime Mail CSS Compressor (mimemail_compress) 7.x-1.0-beta3+
13-dev
Media IMCE (imce) 7.x-1.9
Multilanguage MultiLink (multilink) 7.x-2.10
Multilingual Localization client (l10n_client) 7.x-1.3
Multilingual Localization update (l10n_update) 7.x-1.1
Multilingual - Field translation (i18n_field) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Internationalization (i18n) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Multilingual content (i18n_node) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Multilingual select (i18n_select) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Panels translation (i18n_panels) 7.x-3.4
Internationaliza
tion
Multilingual - String translation (i18n_string) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Taxonomy translation (i18n_taxonomy) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Translation sets (i18n_translation) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Variable translation (i18n_variable) 7.x-1.11+8-dev
Internationaliza
tion
Multilingual - Views translation (i18nviews) 7.x-3.x-dev
Internationaliza
tion
Other Absolute Messages (absolute_messages) 7.x-1.3+13-dev
Other Backup and Migrate (backup_migrate) 7.x-3.0
Other Backup and migrate prune 7.x-2.0-beta1
(backup_migrate_prune)
Other Better Formats (better_formats) 7.x-1.0-beta1
Other Diff (diff) 7.x-3.2+20-dev
Other Disable Password Strength Check 7.x-1.1+0-dev
(disablepwstrength)
Other Entity API (entity) 7.x-1.5
Other Entity Delete Log (entity_delete_log) 7.x-1.1+2-dev
Other Entity tokens (entity_token) 7.x-1.5
Other Environment indicator 7.x-2.5
(environment_indicator)
Other Feedback Simple (feedback_simple) 7.x-1.6+2-dev
Other Flood unblock (flood_unblock) 7.x-1.4
Other Form block (formblock) 7.x-1.0-alpha1
Other Hide submit button (hide_submit) 7.x-2.0+1-dev
Other Libraries (libraries) 7.x-2.2
Other Link checker (linkchecker) 7.x-1.2
Other Linkit (linkit) 7.x-3.2
Other Login Destination (login_destination) 7.x-1.1+0-dev
Other LoginToboggan (logintoboggan) 7.x-1.4
Other Masquerade (masquerade) 7.x-1.0-rc7
Other Menu Block (menu_block) 7.x-2.4
Other Parallax Background (parallax_bg) 7.x-1.2
Other Pathauto (pathauto) 7.x-1.2
Other Rabbit Hole (rabbit_hole) 7.x-2.23
Other Rabbit Hole nodes (rh_node) 7.x-2.23
Other Redirect (redirect) 7.x-1.0-rc1+6-
dev
Other Session Limit (session_limit) 7.x-2.0
Other simplehtmldom API (simplehtmldom) 7.x-2.1
Other Strongarm (strongarm) 7.x-2.0+2-dev
Other Theme Test (themetest) 7.x-1.0
Other Token (token) 7.x-1.5
Other Transliteration (transliteration) 7.x-3.2
Owl Carousel Owl Carousel (owlcarousel) 7.x-1.2
Owl Carousel Owl Carousel UI (owlcarousel_ui) 7.x-1.2
Owl Carousel Owl Carousel Views (owlcarousel_views) 7.x-1.2
Panels Mini panels (panels_mini) 7.x-3.4
Panels Panels (panels) 7.x-3.4
Panels Panels everywhere (panels_everywhere) 7.x-1.0-rc1
Path management Global Redirect (globalredirect) 7.x-1.5+3-dev
Performance and Memcache (memcache) 7.x-1.0
scalability
Rules Rules (rules) 7.x-2.7
Rules Rules Session Vars (rules_session_vars) 7.x-1.0
Rules Rules UI (rules_admin) 7.x-2.7
Rules TACLe Rules (tacle_rules) 7.x-1.0-beta1
Search Database search (search_api_db) 7.x-1.4
Search Search API (search_api) 7.x-1.13
Search Search views (search_api_views) 7.x-1.13
SEO Metatag (metatag) 7.x-1.4+21-dev
SEO Metatag:OpenGraph (metatag_opengraph) 7.x-1.4+21-dev
Spam control CAPTCHA (captcha) 7.x-1.1
Spam control Honeypot (honeypot) 7.x-1.17
Spam control Image CAPTCHA (image_captcha) 7.x-1.1
Spam control Math CAPTCHA (math_captcha) 7.x-1.0-alpha1
Spam control reCAPTCHA (recaptcha) 7.x-1.11
Statistics Google Analytics (googleanalytics) 7.x-2.0
Taxonomy Taxonomy Manager (taxonomy_manager) 7.x-1.0
Taxonomy menu Taxonomy menu (taxonomy_menu) 7.x-1.5
User interface CKEditor (ckeditor) 7.x-1.16
User interface Compact Forms (compact_forms) 7.x-1.0
User interface jQuery Update (jquery_update) 7.x-2.4+5-dev
Variable Variable (variable) 7.x-2.5
Variable Variable realm (variable_realm) 7.x-2.5
Variable Variable store (variable_store) 7.x-2.5
Views Draggableviews (draggableviews) 7.x-2.0+56-dev
Views Views (views) 7.x-3.8
Views Views Bulk Operations 7.x-3.2
(views_bulk_operations)
Views Views Isotope (views_isotope) 7.x-2.0-alpha1
Views Views Slideshow (views_slideshow) 7.x-3.1
Views Views Slideshow: Cycle 7.x-3.1
(views_slideshow_cycle)
Views Views UI (views_ui) 7.x-3.8
XML sitemap XML sitemap (xmlsitemap) 7.x-2.0
XML sitemap XML sitemap engines (xmlsitemap_engines) 7.x-2.0
XML sitemap XML sitemap internationalization 7.x-2.0
(xmlsitemap_i18n)
XML sitemap XML sitemap node (xmlsitemap_node) 7.x-2.0
XML sitemap XML sitemap taxonomy (xmlsitemap_taxonomy) 7.x-2.0

Sorry but the problem still persists.

I updated to the latest dev ( 7.x-1.5-beta1+0-dev ), but there is no change

I think I found something that can help...

In metatag.module the metatag_form_alter() function calls metatag_metatags_form(array &$form, $instance, array $metatags = array(), array $options = array()) function.

I added some dsm() calls to this functions:

function metatag_form_alter(&$form, $form_state, $form_id) {
  if (!empty($form['#metatags']) && !isset($form['metatags'])) {
    extract($form['#metatags']);
    dsm($metatags, 'metatag_form_alter()');  // dsm()
    metatag_metatags_form($form, $instance, $metatags, $options);
    unset($form['#metatags']);
  }
} 

and

...
// Build the form for each metatag.
  foreach ($info['tags'] as $metatag => $metatag_info) {
    // @todo Replace context matching with hook_metatag_access().
    if (isset($options['context']) && isset($metatag_info['context'])) {
      if (!in_array($options['context'], $metatag_info['context'])) {
        continue;
      }
    }
    if ($metatag == 'keywords') dsm($metatags, 'metatag_metatags_form()'); // <--- dsm()
    $metatag_instance = metatag_get_instance($metatag, isset($metatags[$metatag]) ? $metatags[$metatag] : array());
    if (empty($metatag_instance)) {
      continue;
    }

    // Get the form element from the meta tag class.
    $metatag_form = $metatag_instance->getForm($options);
    ...

If I filled in the keywords metatag on taxonomy/term/N/edit page, save it, and than reopen the edit page than the dsm() calls print out some infos ( see image ) and it appears that in line $metatag_instance = metatag_get_instance($metatag, isset($metatags[$metatag]) ? $metatags[$metatag] : array()); the metatag_get_instance() is called with an empty array as second parameter, because $metatags['keywords'] does not exists, but $metatags['und']['keywords'] does.

Because the $data array in metatag_get_instance() function is empty, than in the DrupalTextMetaTag->getForm() function the '#default_value' FAPI element will be an empty string

class DrupalTextMetaTag extends DrupalDefaultMetaTag {

  public function getForm(array $options = array()) {
    $options += array(
      'token types' => array(),
    );

    $form['value'] = isset($this->info['form']) ? $this->info['form'] : array();

    $form['value'] += array(
      '#type' => 'textfield',
      '#title' => $this->info['label'],
      '#description' => !empty($this->info['description']) ? $this->info['description'] : '',
      '#default_value' => isset($this->data['value']) ? $this->data['value'] : '',  // <--- empty string
      '#element_validate' => array('token_element_validate'),
      '#token_types' => $options['token types'],
      '#maxlength' => 1024,
    ); 

The values are saved. If I view the term page, the saved values are in the HTML source, and on Devel tab

Here is the devel ( load )output