Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi
When using varnish + expira + i18N + the wrong paths are banned
included patch resolves this.
Comment | File | Size | Author |
---|---|---|---|
#2 | varnish-i18n-pagecache_clear.patch | 1.59 KB | Mschudders |
Comments
Comment #1
Mschudders CreditAttribution: Mschudders commentedComment #2
Mschudders CreditAttribution: Mschudders commentedComment #3
mgiffordNo longer applies.
Comment #4
doitDave CreditAttribution: doitDave commentedWhat does "no longer applies" mean in connection with "needs work"? The patch no longer works? The error has disappeared (it has not!)? Could you be more verbose on that?
Setting back to "needs review" and hoping for a solution or more communication, since an important frontend cache related module without proper i18n support is really not AAA.
Comment #5
manarth CreditAttribution: manarth as a volunteer commentedIn this context "No longer applies" is a phrase that's often used to mean that the patch does not cleanly apply to the code (usually because commits that have been made since the patch was created have changed the code enough that the patch command cannot figure out how to apply the patch).
It means that the patch needs updating so that it applies cleanly against the current -dev version of the code (in modules with a lot of activity, people often talk about "Chasing head" when a patch repeatedly needs updating because the code moves forward so quickly).
I also noticed that the patch is relative to the Drupal root: ideally, patches for a module are based on the module directory itself (although I appreciate not everyone follows this best practice).
There's a good post about creating patches for core and contrib, which also has some good links and other references.
Comment #6
doitDave CreditAttribution: doitDave commentedI was really hoping for some update on the actual issue rather than best practice. No offense. I will try to find a workaround then.
Comment #7
dshields CreditAttribution: dshields at Canadian Blood Services commentedAny progress?
Comment #8
henk CreditAttribution: henk at RatioWeb for Culture.pl commentedThis is duplicated issue, correct solution is here: https://www.drupal.org/node/2546218