Split off from #2368807: Remove special support for NULL values in FieldItemList

ItemList::setValue() does $item->setvalue($value)
FieldItemList::setValue() does $item->setvalue($value, FALSE)

According to @fago in #2368807-25: Remove special support for NULL values in FieldItemList, that is an oversight, both should do $item->setvalue($value, FALSE)

CommentFileSizeAuthor
#1 2381777-ItemList_FieldItemList_setValue-1.patch2.37 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Postponed
FileSize
2381777-ItemList_FieldItemList_setValue-1.patch2.37 KB

Once #2368807: Remove special support for NULL values in FieldItemList is done, this lets us turn FieldItemList::setValue() into mostly a parent call rather than a full code duplicate

Thus, patch is on top of that issue, and postponed on it.

yched’s picture

yched CreditAttribution: yched commented
Parent issue: » #2368807: Remove special support for NULL values in FieldItemList
yched’s picture

yched CreditAttribution: yched commented
Status: Postponed » Needs review

#2368807: Remove special support for NULL values in FieldItemList is in.

yched’s picture

yched CreditAttribution: yched commented

Green.

Easy RTBC anyone ? @fago already approved in #2368807-25: Remove special support for NULL values in FieldItemList :-)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Thank you.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2381777-ItemList_FieldItemList_setValue-1.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review

Green at home - bot fluke ?

Left a note in #2372855: Add content & config entity dependencies to views, which introduced the code that fails.

yched queued 1: 2381777-ItemList_FieldItemList_setValue-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2381777-ItemList_FieldItemList_setValue-1.patch, failed testing.

Status: Needs work » Needs review

yched queued 1: 2381777-ItemList_FieldItemList_setValue-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2381777-ItemList_FieldItemList_setValue-1.patch, failed testing.

yched’s picture

yched CreditAttribution: yched commented

This makes no sense.
Re-test, hoping to get a different test client.

Status: Needs work » Needs review

yched queued 1: 2381777-ItemList_FieldItemList_setValue-1.patch for re-testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

OK, back to RTBC then.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Less duplicate code - nice. Reduces beta fragility. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 37cdcf8 and pushed to 8.0.x. Thanks!

  • alexpott committed 37cdcf8 on 8.0.x 
    Issue #2381777 by yched: Unify setValue() implementations in ItemList...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.