Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.#2380391: Fix storage settings StringLongItem fixed the storage_settings for string_long field type to no longer have a 'max_length' setting.
The config schema needs to be adjusted accordingly.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2381079-string_long-settings_schema-2.patch | 633 bytes | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedWe should wait for #2370305: Refactor field type configuration schemas for DX, easier to find errors to land though
Comment #2
yched CreditAttribution: yched commentedHere's a patch that applies on top of #2370305: Refactor field type configuration schemas for DX, easier to find errors
(thus, keeping at "Postponed" rather NR)
Comment #3
yched CreditAttribution: yched commented#2370305: Refactor field type configuration schemas for DX, easier to find errors got in
Comment #4
Gábor HojtsyThis is a correct update as of now, string does not have any other settings but max_length. If string is to get more settings though, this may need updates again. File vs. image field does a similar thing because both have unique items but also common items (they inherit from each other). So they have a common base type that both extend in schema. While that would be technically correct here, defining a base type that is an empty mapping does not sound very compelling, so I think this fix is fine.
Comment #5
Gábor HojtsyComment #6
yched CreditAttribution: yched commentedRegarding inheriting the schema : yeah I was not too sure whether it was a good thing or not. I went for explicit schema.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to 8.x. Test coverage looks to be part of #2183983: Find hidden configuration schema issues. Thanks yched.
Comment #9
xjmComment #10
yched CreditAttribution: yched commented@Gábor - regarding the setting's inheritance and schema: actually #2383277: StringLongItem should not extend StringItem is removing the inheritance on the classes, which IMO is a good move.