#2380391: Fix storage settings StringLongItem fixed the storage_settings for string_long field type to no longer have a 'max_length' setting.

The config schema needs to be adjusted accordingly.

Files: 
CommentFileSizeAuthor
#2 2381079-string_long-settings_schema-2.patch633 bytesyched
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,730 pass(es). View

Comments

yched’s picture

yched’s picture

FileSize
633 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,730 pass(es). View

Here's a patch that applies on top of #2370305: Refactor field type configuration schemas for DX, easier to find errors
(thus, keeping at "Postponed" rather NR)

yched’s picture

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

This is a correct update as of now, string does not have any other settings but max_length. If string is to get more settings though, this may need updates again. File vs. image field does a similar thing because both have unique items but also common items (they inherit from each other). So they have a common base type that both extend in schema. While that would be technically correct here, defining a base type that is an empty mapping does not sound very compelling, so I think this fix is fine.

Gábor Hojtsy’s picture

Issue tags: +Configuration system
yched’s picture

Regarding inheriting the schema : yeah I was not too sure whether it was a good thing or not. I went for explicit schema.

  • Dries committed 9809084 on 8.0.x
    Issue #2381079 by yched: Adjust storage_settings schema for string_long...
Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Test coverage looks to be part of #2183983: Find hidden configuration schema issues. Thanks yched.

xjm’s picture

yched’s picture

@Gábor - regarding the setting's inheritance and schema: actually #2383277: StringLongItem should not extend StringItem is removing the inheritance on the classes, which IMO is a good move.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.