Line 312 in facetapi/plugins/facetapi/adapter.inc tries to use $parts[1] before checking for $parts[1] on the next line. Check should come first.

This: 

      $filter = $field_alias . ':' . $parts[1]; // @see https://www.drupal.org/node/1884152
      if (isset($parts[1]) && isset($enabled_aliases[$field_alias])) {

Should be: 

      if (isset($parts[1]) && isset($enabled_aliases[$field_alias])) {
        $filter = $field_alias . ':' . $parts[1]; // @see https://www.drupal.org/node/1884152
CommentFileSizeAuthor
#3 notice_undefined-2378693-3.patch782 bytessylus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

darkodev’s picture

darkodev CreditAttribution: darkodev commented
Issue summary: View changes
darkodev’s picture

darkodev CreditAttribution: darkodev commented
Issue summary: View changes
sylus’s picture

sylus CreditAttribution: sylus commented
Status: Active » Needs review
FileSize
notice_undefined-2378693-3.patch782 bytes

Attaching patch.

darkodev’s picture

darkodev CreditAttribution: darkodev commented
Status: Needs review » Reviewed & tested by the community
darkodev’s picture

darkodev CreditAttribution: darkodev commented

Thanks, @sylus!

candelas’s picture

candelas CreditAttribution: candelas commented

Patch in #3 works. Thanks @sylus ;)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-1.5 » 7.x-1.x-dev

+1 for the patch, and it still applies against the latest 7.x-1.x codebase.

das-peter’s picture

das-peter CreditAttribution: das-peter at Cando commented

Still applies and helps to reduce the noise in the logs.
Let's get this in!

pau1_m’s picture

pau1_m CreditAttribution: pau1_m commented

+1 for patch #3

jbiechele’s picture

jbiechele CreditAttribution: jbiechele commented

+1 for patch #3

krystianbuczak’s picture

krystianbuczak CreditAttribution: krystianbuczak commented

+1 for patch #3

darkodev’s picture

darkodev CreditAttribution: darkodev commented

+1 for patch in #3

candelas’s picture

candelas CreditAttribution: candelas as a volunteer commented

+1 for patch in #3

candelas’s picture

candelas CreditAttribution: candelas as a volunteer commented

By the way, they are seeking for a new maintainer. I have not the level, but maybe someone here... :)

BLOK-Man’s picture

BLOK-Man CreditAttribution: BLOK-Man commented

thanks patch #3

  • drumm committed 0e306dc on 7.x-1.x authored by sylus 
    Issue #2378693 by sylus: Notice: Undefined offset: 1 in FacetapiAdapter...
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Looks good! Committed.

rovo’s picture

rovo
Location Delaware
CreditAttribution: rovo commented

Also was having this issue but now resolved. Thank you!

FYI for anyone else, drush dl facetapi --dev , pulls the latest 7.x-2.x-dev that doesn't have this patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

darkodev’s picture

darkodev CreditAttribution: darkodev commented

Can we expect a 7.x-1.6 with this rolled in?

darkodev’s picture

darkodev CreditAttribution: darkodev commented

RTBC +