Problem/Motivation

The right sidebar on the node creation page looks bad, due to the border and the default browser outline effect. I suggest we improve the theming to make the sidebar look better. Currently the 'sidebar' looks like this:

node/add/article:
-

Proposed resolution

I suggest we fix the border issues and the outline. Currently I've created a patch that makes the sidebar looks like this:

node/add/article:
-

Remaining tasks

  • Finalize and agree on the visual design
  • Write the patch

User interface changes

Updated look for the right sidebar for content

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sqndr’s picture

Status: Active » Needs review
FileSize
1.85 KB

Here we go with the patch. Let's get some reviews!

Status: Needs review » Needs work

The last submitted patch, 1: block_node_entity_meta-2375663-1.patch, failed testing.

sqndr’s picture

FileSize
1.52 KB

I think the test broke because I added a new css file. Here's a new patch that should fix the test. Also a small change in the order of the new stylesheet inside the info file.

sqndr’s picture

Status: Needs work » Needs review
FileSize
2.99 KB

Damn it. Here's the patch. The interdiff is in the comment above, sorry ;)

sqndr’s picture

Look's like I forget a new line in the new block.css file. Also forgot the change the key in the test. Patching too early in the morning can be bad … :D

sqndr’s picture

Title: Block/Node Entity Meta Theming » Block/Node/Entity Meta Theming

The last submitted patch, 4: block_node_entity_meta-2375663-4.patch, failed testing.

sqndr’s picture

Issue summary: View changes
LewisNyman’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

Doh! Does not apply. This is looking better though. I think the filename 'block.css' is too generic. Can we name it to match the 'block-list-secondary' class?

LewisNyman’s picture

Also, can we remove the inner shadow? It doesn't really fit with the Seven visuals

sqndr’s picture

Issue summary: View changes

I think the filename 'block.css' is too generic. Can we name it to match the 'block-list-secondary' class

Also, can we remove the inner shadow? It doesn't really fit with the Seven visuals

Sure. ;)

MiSc’s picture

Assigned: Unassigned » MiSc
MiSc’s picture

Assigned: MiSc » Unassigned

Took a quick look at this, but the testing part seems to have moved the css files, or the way it is done, so I got stuck.

sqndr’s picture

I'll give the latest patch another test run.

The last submitted patch, 5: block_node_entity_meta-2375663-5.patch, failed testing.

sqndr’s picture

MiSc, there is still some work to-do for this issue. Here's some great documentation on how to re-roll a patch. Afterwards, there are two more tasks that should happen. They are described in the issue summary (and comment #11). Cheers ;)

thisisit’s picture

Assigned: Unassigned » thisisit
piyuesh23’s picture

Issue tags: +#DCM2015
thisisit’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
7.08 KB

Re rolling #5.

Status: Needs review » Needs work

The last submitted patch, 20: block_node_entity_meta-2375663-20.patch, failed testing.

sqndr’s picture

Issue tags: +Novice, +Needs reroll
sqndr’s picture

The work from #9, #10, #11 still needs to be done.

piyuesh23’s picture

Status: Needs work » Needs review
FileSize
11.66 KB

Re-rolled & updated patch with 9, #10 & #11

Status: Needs review » Needs work

The last submitted patch, 24: block_node_entity_meta-2375663-24.patch, failed testing.

Bojhan’s picture

LewisNyman’s picture

Issue tags: -Novice, -Needs reroll +Usability
LewisNyman’s picture

index be2759f..4473860 100644
--- a/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php

--- a/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php
+++ b/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php

+++ b/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php
@@ -171,6 +171,46 @@ public function testRebuildThemeData() {

@@ -171,6 +171,46 @@ public function testRebuildThemeData() {
 
     $this->assertEquals('twig', $info->info['engine']);
     $this->assertEquals(array('seven/global-styling'), $info->info['libraries']);
+    $this->assertEquals(array(), $info->info['libraries']);

This patch contains changes to tests that are from another patch, that's why the tests are failing

piyuesh23’s picture

Status: Needs work » Needs review
FileSize
11.6 KB

Uploading a patch with cleaned tests.

Status: Needs review » Needs work

The last submitted patch, 29: block_node_entity_meta-2375663-29.patch, failed testing.

yoroy’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
121.85 KB
64.94 KB

This sidebar seems too boxed in at the moment. In exploring options I took cues from the modules page. Instead of one solid boxed-in column with sections separated by grey lines we can give it some more air by removing the thin grey borders by white space. We don't necessarily need visual difference between a closed and an open section, so I simplified that as well.

Not sure yet about the best background color yet, but looks like a promising direction. Thoughts?

LewisNyman’s picture

Category: Bug report » Task
Status: Needs review » Needs work

@yoroy Thanks for working on this, the "Place blocks" title and search input feel very separate from the blocks now. I think that it needs some kind of container to associate them. Maybe we can take inspiration from the config page panels, that contains a and groups?

thisisit’s picture

Assigned: thisisit » Unassigned

My apologies this is still assigned to me and didn't even realise this as this was my first attempt to re-roll. This will probably need some usability expert.

Sakthivel M’s picture

Status: Needs work » Needs review
FileSize
2.03 KB
8.92 KB
10.59 KB

Hi,
I have created a patch to solve the issue mentioned

patch
patch

Status: Needs review » Needs work

The last submitted patch, 34: Block_Node_Entity_Meta.patch, failed testing.

Sakthivel M’s picture

Status: Needs work » Needs review
FileSize
2.07 KB
10.59 KB
8.92 KB

Hi,
I have re created a patch to solve the issue mentioned

patch
patch

Status: Needs review » Needs work

The last submitted patch, 36: Block_Node_Entity_Meta.patch, failed testing.

Manjit.Singh’s picture

Version: 8.0.x-dev » 8.2.x-dev
Status: Needs work » Needs review
FileSize
1.96 KB

I guess this patch should be move into 8.2.x that is why automated testing fail in #36.

Status: Needs review » Needs work

The last submitted patch, 38: Block_Node_Entity_Meta-2375663-37.patch, failed testing.

emma.maria’s picture

Issue tags: +Needs usability review

I'm going to take the attention back to comment #31 where the UI design was under discussion again.
No more patches for the meantime please :-)

@yoroy did you have any feedback for #32?

Bojhan’s picture

Issue tags: -Needs usability review

@yoroy What do you think? It looks a bit barebones to me

yoroy’s picture

Title: Block/Node/Entity Meta Theming » Node/Entity Meta Theming
Issue summary: View changes
FileSize
254.28 KB
245.78 KB

Updated the issue summary a bit: the right sidebar for Blocks ui was rolled back (is not in core). Most of the feedback in #32 doesn't apply anymore.

@Bojhan I agree it looks sparse, that's what you get when I design it :)

We have something similar at /admin/structure/types/manage/article/form-display, where if you expand the config options for a single field (click the far right cog icon) we show that expanded row with a blue background. I don't think it's a great look, but we could apply a similar approach here:

related: the whole thing starts to look a lot friendlier with some rounded corners:

yoroy’s picture

Issue tags: +Needs design
yoroy’s picture

Title: Node/Entity Meta Theming » Update the design for the right sidebar on content creation page

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

markconroy’s picture

Let's move this to the Seven contrib module issue queue. Core is now using Claro by default, which has a really nice looking sidebar.

mherchel’s picture

Project: Drupal core » Seven
Version: 10.1.x-dev » 1.0.0-alpha1
Component: Seven theme » Code

+1 Moving it to Seven.