Hi,

Because menu title could sometime being already escaped with check_plain title callback, it should not always being done.
See _menu_item_localize().

Here is a patch.

Thanks

CommentFileSizeAuthor
#4 Screen Shot 2014-12-30 at 12.11.27 PM.png28.07 KBkyletaylored
#1 2375205-breadcrumb_title-1.patch484 byteschaby
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chaby’s picture

chaby CreditAttribution: chaby commented
Status: Active » Needs review
FileSize
2375205-breadcrumb_title-1.patch484 bytes
kyletaylored’s picture

kyletaylored CreditAttribution: kyletaylored commented

@Chaby, could you post an example module we can test this use-case against? I just want to confirm it before it's committed.

Thanks!

chaby’s picture

chaby CreditAttribution: chaby commented

@kyletaylored, with node module, create a content type with a label/title like "l'éléphant PHP". Then go to node/add/CONTENT_TYPE and see the breadcrumb title.

kyletaylored’s picture

kyletaylored CreditAttribution: kyletaylored commented
Assigned: Unassigned » kyletaylored
Status: Needs review » Fixed
FileSize
Screen Shot 2014-12-30 at 12.11.27 PM.png28.07 KB

Yep, I can confirm this issue. It can also be explained under _menu_item_localize(). It's not just if it's empty, but if it's set to true, to verify the callback is check_plain.

menu item localize

Fixed!

  • kyletaylored committed 031b5f5 on 7.x-4.x authored by chaby 
    Issue #2375205 by chaby, kyletaylored: Breadcrumb titles should not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.