d8 navbar affected [#2375181]

drupal: 8-beta3
youtube: 8.x-1.x-dev (2014-Oct-30)

module (fieldtype) works as expected but seems to have some negative 'sideeffects' on drupal's navbar menu structure, which have to be fixed in future versions.

- Toolbar items
- User account menu
- Main navigation

Comment	File	Size	Author
#2	youtube-d8-hook-page-attachments-2375181-2.patch	411 bytes	guschilds
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

15 November 2014 at 19:11

guschilds committed aa58968 on 8.x-1.x

Issue #2375181 by wschleicher, guschilds: Swapped deprecated...

Comment #2

guschilds CreditAttribution: guschilds commented 15 November 2014 at 19:15

Status:

Active

» Fixed

File	Size
youtube-d8-hook-page-attachments-2375181-2.patch	411 bytes

Thanks for pointing this out, wschleicher.

After digging into it, I determined that it was caused by how the module is using hook_page_build(), which was deprecated in Drupal 8 beta3 for hook_page_attachments() in #2350949: Add hook_page_attachments(_alter)() and deprecate hook_page_build/alter().

I switched youtube_page_build() to youtube_page_attachments() (see attached patch) and it fixed the bug. I've committed this fix to the 8.x-1.x branch.

Thanks again!