Feeds Tamper UI incorrectly uses hook_menu:

$defaults = array(
  'page callback' => 'drupal_get_form',
  'access callback' => 'feeds_tamper_access',
  'access arguments' => array(5),
  'file' => 'feeds_tamper_ui.admin.inc',
  'title arguments' => array(5),
  'type' => MENU_CALLBACK,
);

$items['feeds_tamper/js'] = array(
  'page callback' => 'feeds_tamper_ui_js',
  'access callback' => TRUE,
) + $defaults;

Causing incorrect title arguments assigned to the menu item in question. This minor issue forces Drupal to load theme resulting in being incompatible with ThemeKey module.

CommentFileSizeAuthor
#1 feeds_tamper-2374525-1.patch883 bytesTaran2L
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Taran2L’s picture

Status: Active » Needs review
FileSize
883 bytes

Patch attached. Please review.

  • twistor committed a9b85d5 on 6.x-1.x authored by Taran2L
    Issue #2374525 by Taran2L: Feeds Tamper UI incorrectly uses hook_menu
    
twistor’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Needs review » Fixed
Taran2L’s picture

Thanks for committing this one so fast!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.