Problem/Motivation

See parent issue #2296447: Develop basic test coverage for SMS Framework

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#7 interdiff.txt1.55 KBalmaudoh
#7 sms_valid_tests-2374043-7.patch15.35 KBalmaudoh
#6 interdiff.txt3.19 KBalmaudoh
#6 sms_valid_tests-2374043-6.patch14.91 KBalmaudoh
#4 sms_valid_tests-2374043-4.patch15.96 KBalmaudoh
#4 interdiff.txt10.51 KBalmaudoh
#1 sms_valid_tests-2374043-1.patch11.55 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Active » Needs review
FileSize
sms_valid_tests-2374043-1.patch11.55 KB

Added tests and modified some other code to fit.

Status: Needs review » Needs work

The last submitted patch, 1: sms_valid_tests-2374043-1.patch, failed testing.

Status: Needs work » Needs review

almaudoh queued 1: sms_valid_tests-2374043-1.patch for re-testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
FileSize
interdiff.txt10.51 KB
sms_valid_tests-2374043-4.patch15.96 KB

Added more tests. Interdiff is quite big.

Status: Needs review » Needs work

The last submitted patch, 4: sms_valid_tests-2374043-4.patch, failed testing.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs work » Needs review
FileSize
sms_valid_tests-2374043-6.patch14.91 KB
interdiff.txt3.19 KB

Oops!! ;) used php 5.4 syntax for D7 :P

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
FileSize
sms_valid_tests-2374043-7.patch15.35 KB
interdiff.txt1.55 KB

Added one more test.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Needs review » Fixed

Committed / pushed to 7.x-1.x

  • almaudoh committed cc21b46 on 7.x-1.x 
    Issue #2374043 by almaudoh: Provide basic test coverage for sms...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.