Missing block type column in custom block library listing

This is mostly a UX thing, but a pretty big one IMO. Currently, it's impossible to see what block type a custom block belongs to in de administration overview listing page at structure -> block layout- > custom block library.

Reproduce:

1. Create at least one other block type (beside the default basic block) at admin/structure/block/block-content/types/add
2. Create some custom blocks at block/add using the various block types made in step 1.
3. Go to the block listing library at admin/structure/block/block-content

You will see the blocks with the block description in the first column and an operations column with the edit/delete actions. But there is no way to see what block type it is in this screen, or in any other screen.

Comment	File	Size	Author
#16	block-type-listing-2373283.15.patch	3.39 KB	larowlan
#16
#16	interdiff.txt	793 bytes	larowlan
#14	block-type-listing-2373283.14.patch	3.38 KB	larowlan
#14
#14	interdiff.txt	1.5 KB	larowlan
#9	block-type-listing-2373283.pass_.patch	1.88 KB	larowlan
#9
#9	block-type-listing-2373283.fail_.patch	812 bytes	larowlan
#9
#4	missing-block-type-2373283-4.patch	913 bytes	askibinski
#4
#3	missing-block-type-2373283-3.diff	913 bytes	askibinski
#3
#1	Custom_block_library___Merge.png	239.58 KB	askibinski

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

askibinski CreditAttribution: askibinski commented 11 November 2014 at 16:23

File	Size
Custom_block_library___Merge.png	239.58 KB

Added screenshot which explains it in one picture.

Log in or register to post comments

Comment #2

askibinski CreditAttribution: askibinski commented 11 November 2014 at 16:38

Component:

block.module

» custom_block.module

Changing it to the right component.

Log in or register to post comments

Comment #3

askibinski CreditAttribution: askibinski commented 11 November 2014 at 17:37

File	Size
missing-block-type-2373283-3.diff	913 bytes

I made a patch which adds this column to the listing.

However, $entity->bundle() returns the machine name of the bundle, not the bundle label, and I can't find how to return the bundle label. It doesn't seem to be part of the entity api documentation yet.

Log in or register to post comments

Comment #4

askibinski CreditAttribution: askibinski commented 11 November 2014 at 17:40

File	Size
missing-block-type-2373283-4.patch	913 bytes

1 file was hidden/shown/deleted

File	Size
missing-block-type-2373283-3.diff	913 bytes

Wrong extension for the patch.

Log in or register to post comments

larowlan’s picture

Comment #5

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 23 December 2014 at 21:37

Status:

Active

» Needs review

Log in or register to post comments

Comment #6

German

CreditAttribution: dawehner commented 23 December 2014 at 23:44

+1 ... do we maybe need to add a test to ensure its there?

Log in or register to post comments

larowlan’s picture

Comment #7

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 23 December 2014 at 23:56

Issue tags:

Log in or register to post comments

Comment #8

24 December 2014 at 01:06

Status:

Needs review

» Needs work

The last submitted patch, 4: missing-block-type-2373283-4.patch, failed testing.

Log in or register to post comments

larowlan’s picture

Comment #9

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 3 January 2015 at 07:03

Status:	Needs work	» Needs review
Issue tags:	-Needs tests

File	Size
block-type-listing-2373283.fail_.patch	812 bytes

block-type-listing-2373283.pass_.patch	1.88 KB

should be red/green

Log in or register to post comments

Comment #10

3 January 2015 at 07:23

Status:

Needs review

» Needs work

The last submitted patch, 9: block-type-listing-2373283.pass_.patch, failed testing.

Log in or register to post comments

Comment #11

3 January 2015 at 07:24

The last submitted patch, 9: block-type-listing-2373283.fail_.patch, failed testing.

Log in or register to post comments

Comment #12

4 January 2015 at 04:51

Status:

Needs work

» Needs review

larowlan queued 9: block-type-listing-2373283.pass_.patch for re-testing.

Log in or register to post comments

Comment #13

4 January 2015 at 05:12

Status:

Needs review

» Needs work

The last submitted patch, 9: block-type-listing-2373283.pass_.patch, failed testing.

Log in or register to post comments

larowlan’s picture

Comment #14

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 5 January 2015 at 07:45

Status:

Needs work

» Needs review

File	Size
interdiff.txt	1.5 KB
block-type-listing-2373283.14.patch	3.38 KB

Log in or register to post comments

Comment #15

5 January 2015 at 08:05

Status:

Needs review

» Needs work

The last submitted patch, 14: block-type-listing-2373283.14.patch, failed testing.

Log in or register to post comments

larowlan’s picture

Comment #16

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 5 January 2015 at 08:08

Status:

Needs work

» Needs review

File	Size
interdiff.txt	793 bytes
block-type-listing-2373283.15.patch	3.39 KB

doh

Log in or register to post comments

Comment #17

askibinski CreditAttribution: askibinski commented 5 January 2015 at 09:28

Cool, looks good to me :)

Log in or register to post comments

webchick’s picture

Comment #18

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 12 January 2015 at 17:04

Component:

custom_block.module

» block_content.module

Log in or register to post comments

larowlan’s picture

Comment #19

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 14 March 2015 at 07:27

Status:

Needs review

» Closed (duplicate)

Let's focus on #2375589: Convert custom block library page to views instead

Log in or register to post comments