This is mostly a UX thing, but a pretty big one IMO. Currently, it's impossible to see what block type a custom block belongs to in de administration overview listing page at structure -> block layout- > custom block library.

Reproduce:

1. Create at least one other block type (beside the default basic block) at admin/structure/block/block-content/types/add
2. Create some custom blocks at block/add using the various block types made in step 1.
3. Go to the block listing library at admin/structure/block/block-content

You will see the blocks with the block description in the first column and an operations column with the edit/delete actions. But there is no way to see what block type it is in this screen, or in any other screen.

Files: 
CommentFileSizeAuthor
#16 block-type-listing-2373283.15.patch3.39 KBlarowlan
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,361 pass(es). View
#16 interdiff.txt793 byteslarowlan
#14 block-type-listing-2373283.14.patch3.38 KBlarowlan
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,375 pass(es), 1 fail(s), and 0 exception(s). View
#14 interdiff.txt1.5 KBlarowlan
#9 block-type-listing-2373283.pass_.patch1.88 KBlarowlan
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,359 pass(es), 4 fail(s), and 1 exception(s). View
#9 block-type-listing-2373283.fail_.patch812 byteslarowlan
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,357 pass(es), 1 fail(s), and 0 exception(s). View
#4 missing-block-type-2373283-4.patch913 bytesaskibinski
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,780 pass(es), 4 fail(s), and 1 exception(s). View
#1 Custom_block_library___Merge.png239.58 KBaskibinski

Comments

askibinski’s picture

Added screenshot which explains it in one picture.

askibinski’s picture

Component: block.module » custom_block.module

Changing it to the right component.

askibinski’s picture

I made a patch which adds this column to the listing.

However, $entity->bundle() returns the machine name of the bundle, not the bundle label, and I can't find how to return the bundle label. It doesn't seem to be part of the entity api documentation yet.

askibinski’s picture

FileSize
913 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,780 pass(es), 4 fail(s), and 1 exception(s). View

Wrong extension for the patch.

larowlan’s picture

Status: Active » Needs review
dawehner’s picture

+1 ... do we maybe need to add a test to ensure its there?

larowlan’s picture

Issue tags: +Needs tests

Status: Needs review » Needs work

The last submitted patch, 4: missing-block-type-2373283-4.patch, failed testing.

larowlan’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
812 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,357 pass(es), 1 fail(s), and 0 exception(s). View
1.88 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,359 pass(es), 4 fail(s), and 1 exception(s). View

should be red/green

Status: Needs review » Needs work

The last submitted patch, 9: block-type-listing-2373283.pass_.patch, failed testing.

The last submitted patch, 9: block-type-listing-2373283.fail_.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: block-type-listing-2373283.pass_.patch, failed testing.

larowlan’s picture

Status: Needs work » Needs review
FileSize
1.5 KB
3.38 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,375 pass(es), 1 fail(s), and 0 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 14: block-type-listing-2373283.14.patch, failed testing.

larowlan’s picture

Status: Needs work » Needs review
FileSize
793 bytes
3.39 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,361 pass(es). View

doh

askibinski’s picture

Cool, looks good to me :)

webchick’s picture

Component: custom_block.module » block_content.module
larowlan’s picture

Status: Needs review » Closed (duplicate)