[D7] Translation importer

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

57 | WARNING | Line exceeds 80 characters; contains 86 characters
Only error is from a URL, shouldn't be a problem.

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation.

Master Branch

Follows the guidelines for master branch.

Licensing

Follows the licensing requirements.

README.txt/README.md

Follows the guidelines for in-project documentation except for the one too long line containing a URL.

Code long/complex enough for review

Follows the guidelines for project length and complexity. Code is over 120 lines if the tests are counted to the LOC. Function/Class count is OK.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

Seemed fine.

This review uses the Project Application Review Template.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmikran2371049git

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Mikran,

The structure of the module looks really good! Congrats.

Manual Review:
1.
class TranslationImporterStreamWrapper extends DrupalLocalStreamWrapper {}
I don't know, in my opnion I think is always better isolate the class on a separated file, and list it on .info file. What do you think?

2.

/**
 * Implements hook_uninstall().
 */
function translation_importer_uninstall() {
  variable_del('file_translations_path');
  variable_del('translation_importer_catalog_hashes');
}

Is a good practice, use the module name as a variable prefix to avoid conflict, like translation_importer_xxxxxxx.

So using the name of the module as a prefix, you can do something like this:

/**
 * Implements hook_uninstall().
 */
function translation_importer_uninstall() {
  // Deleting variables.
  db_delete('variable')->condition('name', 'translation_importer_%', 'LIKE')->execute();
}

Just comments ;)

Automated Issues:

################################ Coder Sniffer #################################

FILE: .../jribeiro/Projects/git/translation_importer/translation_importer.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 67 | ERROR | Missing parameter type at position 1
 70 | ERROR | Missing parameter type at position 2
--------------------------------------------------------------------------------


FILE: /home/jribeiro/Projects/git/translation_importer/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 57 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------

http://pareview.sh/pareview/httpgitdrupalorgsandboxmikran2371049git

RTBC, looks great.

Guidelines are followed, found no security problems.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.