Problem/Motivation

#2317557: renderInline not compatible with twig_auto_reload fixed rendering inline in case reload is enabled. Sadly the tests never really have been done properly.
It is still using


$settings = Settings::getAll();
$settings['twig_debug'] = TRUE;
$settings['twig_auto_reload'] = TRUE;

Proposed resolution

Remove the second part of the test given that it does not add any value OR fix the test to actually rebuild the container using new
parameters.

Remaining tasks

User interface changes

API changes

Comments

filippo.ledda’s picture

Assigned: Unassigned » filippo.ledda
filippo.ledda’s picture

Status: Active » Needs work
Issue tags: +#drupalsprintIT
FileSize
1.27 KB

Second part of the test removed as suggested, but I'm not sure I really got all the point. I'd need more info to figure out how to improve it.

Alienpruts’s picture

Agreed, I also took a look at this, but concluded that we didn't have enough information to properly fix this.. :) Remember, we are novices here :)

filippo.ledda’s picture

Assigned: filippo.ledda » Unassigned
Alienpruts’s picture

Status: Needs work » Postponed (maintainer needs more info)

I'm setting this to "Maintainer needs more info" (I know, we aren't maintainers, but we need more info :) )

joelpittet’s picture

Status: Postponed (maintainer needs more info) » Needs review
Issue tags: -Novice +rc eligible
FileSize
1.15 KB

This should be fine to move forward with a fix.

Here should fix the Twig. @dawhener helped me a bit sort out the way to keep the changed parameters by not rebuilding it when we are using a KernalTestBase.

Status: Needs review » Needs work

The last submitted patch, 6: twigenvironmenttest_has-2372767-6.patch, failed testing.

Cottser’s picture

Version: 8.0.x-dev » 8.1.x-dev

I think I wrote the original test for twig_debug etc. years ago and it took a lot of digging and asking people to even figure out how to do it. Anyway, based on the test fail of #6 not sure on how to move forward here :)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.