I am getting a blank image link next to the google cse search box at .../search/google. The blank image has a url linking to "http://fusion.google.com/add?moduleurl=http%3A%2F%2Fwww.google.com%2Fcoo........"(remainder redacted)

Any ideas what is going on? not sure if it is a bug or not? Search results works normally for both site content and site images.

CommentFileSizeAuthor
#11 remove_broken_add_to-2372069-11.patch3.55 KBmalcomio
#8 2372069-remove-broken-fusion-gadget-7.patch3 KBaaron.ferris
#5 2372069-remove-broken-fusion-gadget-5.patch1.98 KBaaron.ferris
#1 screencapture-trainingcity-com-en-search-google.png84.17 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
screencapture-trainingcity-com-en-search-google.png84.17 KB
aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented

This looks like code being pulled from google_cse_results_gadget.tpl.php

<?php
?>

<div id="google-cse-results-gadget">
  <a
    href="http://fusion.google.com/add?moduleurl=http%3A%2F%2Fwww.google.com%2Fcoop/api/<?php print $creator; ?>/cse/<?php print $id; ?>/gadget">
    <img src="https://www.google.com/ig/images/plus_google.gif" width="62"
         height="17" border="0" alt="<?php print t('Add to Google'); ?>"/>
  </a>
</div>

Trouble being that image source is dead, doing some reading looks like fusion is much the same.

http://www.webmasterworld.com/webmaster/4660739.htm

Would be good to patch this out of the module, but in the mean time you can disable the gadget by going to ;

/admin/config/search/settings and unchecking 'Search results "Add to Google" Google Gadget'

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Thanks aaron.ferris. That solved the problem for me, much appreciated.

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented

Welcome! Ill sort a patch for this when I get 5 minutes.

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
FileSize
2372069-remove-broken-fusion-gadget-5.patch1.98 KB
aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
Priority: Normal » Minor
Status: Active » Needs review
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer commented
Title: Blank Image link to fusion.google.com » Remove broken 'add to google' gadget functionality
Status: Needs review » Needs work

Thanks for fixing this aaron.ferris@capgemini.com. Few concerns:

1. 

+++ b/google_cse.admin.inc
@@ -59,12 +59,6 @@ function google_cse_admin_settings() {
-  $form['google_cse']['google_cse_results_gadget'] = array(

may be worth adding an hook_update_n to remove this variable?

2.

function google_cse_theme($existing, $type, $theme, $path) {
...
 'google_cse_results_gadget' => array(
      'variables' => array(),
      'file' => 'google_cse.theme.inc',
      'template' => 'google_cse_results_gadget',
    ),

We may need to remove this them register.

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
FileSize
2372069-remove-broken-fusion-gadget-7.patch3 KB

Thanks Vijay.

aaron.ferris’s picture

aaron.ferris CreditAttribution: aaron.ferris commented
Version: 7.x-2.x-dev » 7.x-2.3
Status: Needs work » Needs review
malcomio’s picture

malcomio CreditAttribution: malcomio commented
Status: Needs review » Needs work

Patch no longer applies

malcomio’s picture

malcomio CreditAttribution: malcomio commented
Status: Needs work » Needs review
FileSize
remove_broken_add_to-2372069-11.patch3.55 KB

  • malcomio committed 534e5d0 on 7.x-2.x 
    Issue #2372069 by aaron.ferris, malcomio: Remove broken 'add to google'...
malcomio’s picture

malcomio CreditAttribution: malcomio commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.