captcha.module 5.x-3.x is about 800 lines of code, of which only a fraction is needed on each page view. It would be a good idea to refactor some stuff out to include files like captcha.admin.inc and captcha.pages.inc to make captcha.module smaller and reduce the related overhead. Same for image CAPTCHA.

Doing so (and with the help of the new drupal 6 feature http://drupal.org/node/146172) captcha.module HEAD is already reduced to only about 250 lines of code.

We could do this for 5.x-3.x too, but only when no other big changes are under development, so we don't break those patches is a hard way.
e.g. I'd like to commit http://drupal.org/node/214557 and http://drupal.org/node/188599 first

Comments

soxofaan’s picture

soxofaan CreditAttribution: soxofaan commented

moved already about 260 lines of code from image_captcha.module to image_captcha.user.inc: http://drupal.org/cvs?commit=112576

soxofaan’s picture

soxofaan CreditAttribution: soxofaan commented

moved about 230 LOC from image_captcha.module to image_captcha.admin.inc: http://drupal.org/cvs?commit=112622

soxofaan’s picture

soxofaan CreditAttribution: soxofaan commented
Status: Active » Closed (won't fix)

Closing issues for 5.x releases, which is officially unsupported now.