Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This issue: #1920862: Rename custom_block.module to block_content.module renamed the code bits of of custom_block to block_content, but some instances of labels and comments were missed. This is a followup issue to do that renaming.
Comment | File | Size | Author |
---|---|---|---|
#21 | Custom Block 2015-03-22 at 3.40.45 PM.png | 36.87 KB | saltednut |
#21 | Custom Block 2015-03-22 at 3.41.00 PM.png | 53.97 KB | saltednut |
#21 | Custom Block 2015-03-22 at 3.40.34 PM.png | 52.57 KB | saltednut |
#21 | Custom Block 2015-03-22 at 3.40.24 PM.png | 66.49 KB | saltednut |
#21 | Custom Block 2015-03-22 at 3.39.54 PM.png | 99.51 KB | saltednut |
Comments
Comment #1
nadavoid CreditAttribution: nadavoid commentedPatch attached that updates comments and labels.
The phrase "custom block" was used differently in several places, so some wording that was updated to "block content" may still need to be adjusted. I've also attached a word diff with more context, to make it easier to review.
Here's the change overview:
Comment #2
nadavoid CreditAttribution: nadavoid commentedComment #3
nadavoid CreditAttribution: nadavoid commentedHere are some initial examples, for review. Since the word "custom" was dropped from the module, one of the main things in the other language is to remove the word custom and at least start the phrase with the word "block."
Comment #5
nadavoid CreditAttribution: nadavoid commentedThis should fix the failed test.
Comment #6
nadavoid CreditAttribution: nadavoid commentedComment #7
rpayanm@nadavoid you last patch is 0 byte :(
Comment #8
Bojhan CreditAttribution: Bojhan commentedCould you explain to me why we are changing these labels? API change is not really an argument, since we don't have to name API and UI labels the same - this is an established practice within core.
Comment #9
nadavoid CreditAttribution: nadavoid commentedComment #10
tim.plunkett@Bojhan, the original motivation for this issue was confusion in dropdowns when "Block" and "Custom block type" are nowhere near each other, compared to how it would be if it was "Block" and "Block content type"
Comment #11
nadavoid CreditAttribution: nadavoid commentedThe origin of this change was that after creating a custom block type and then a block from that new block type, I went to the single export page and was confused about how to export the new block type. At first I thought the block type option was missing, but Tim Plunkett pointed out that it's "Custom Content Blocks." My confusion was only because I was expecting all Block exports to be adjacent to each other, starting with the word "Block." Tim pointed out that since the entity type had been renamed from custom block to block content, and that following that up by updating labels and comments would clarify the list that I was originally looking at. It would also improve consistency between user-facing labels and corresponding machine names.
So that's the background and the reason. Whether it's entirely a good thing or needed or how far to take it is what I would like feedback on. It's good to know now that it's an established practice in drupal core to name UI labels sometimes slightly differently from API names. (although this sometimes leads to confusion) Now that I know the proper thing to select when exporting individual blocks and block types, my immediate issue is resolved. So perhaps the label aspect of this could be considered a training issue on my part.
Comment #12
nadavoid CreditAttribution: nadavoid commentedThanks for the screen shot Tim. :)
Comment #13
jhodgdonSo the reason for changing all of these labels is just for the Config export? That doesn't seem like a really great idea to me, because I think in most or all other contexts, people probably think of these entities as "custom blocks", not "block content". Most people will probably never be exporting or importing config for these anyway... it seems like you're throwing out an intuitive label in favor of a less intuitive label, for a developer edge case.
Comment #14
tim.plunkettNo, that was not the entire reason. That was an example that I could screenshot easily to demonstrate the confusion.
"Custom blocks" is very misleading in D8, because of the two-step nature of blocks. There was a lot of thought put into the new name of "block content" and "block content type", because that's what they are.
Comment #15
jhodgdonI guess some before/after screen shots of where all these changes appear in the UI would be helpful. Presumably that would help the Usability team evaluate whether the changes all make sense in context.
Comment #17
saltednutComment #19
saltednutComment #20
saltednutThese are the "after" screenshots I could find.
Comment #21
saltednutThese are the "before" screenshots I could find.
Comment #22
Bojhan CreditAttribution: Bojhan as a volunteer commentedDid we update on the latest thinking around this?
Comment #34
smustgrave CreditAttribution: smustgrave at Mobomo commentedWondering if this is still needed know it's been several years.
Comment #36
smustgrave CreditAttribution: smustgrave at Mobomo commentedSo rechecked 11.x and not seeing custom block phrase being used. So think this is probably old.