Due to changes in head global redirect pretty much fatals on lots of paths.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, id-fatal.patch, failed testing.

marcingy’s picture

Assigned: Unassigned » marcingy

Will look at this tomorrow

marcingy’s picture

Status: Needs work » Needs review
FileSize
4.12 KB

Tests are passing locally, there is an item follow up on but core is still heavily using the function currently so happy as a stop gap, basically can't workout how to get Url::fromUri to give me an aliased path at end of day yet from generateFromPath does the trick.

Status: Needs review » Needs work

The last submitted patch, 3: fix-fatal.patch, failed testing.

marcingy’s picture

Status: Needs work » Needs review
FileSize
4.84 KB

Does help if I remember to also add the updated services.yml file

slashrsm’s picture

Status: Needs review » Needs work
+++ b/src/EventSubscriber/GlobalredirectSubscriber.php
@@ -206,20 +211,27 @@ class GlobalredirectSubscriber implements EventSubscriberInterface {
+      try {
+        $result = \Drupal::service('router')->match('/' . $path);
+      }
+      catch (ResourceNotFoundException $e) {

Inject?

marcingy’s picture

Status: Needs work » Needs review
FileSize
5.58 KB
slashrsm’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

loopduplicate’s picture

The patch in #7 works for me too.

loopduplicate’s picture

Assigned: marcingy » Unassigned
Berdir’s picture

Not sure how exactly this overlaps with the changes that we've been working on in our github repository, see #2332377: Chase HEAD.

Berdir’s picture

Ok, that issue is failing on the testbot, want to propose your patch as a pull request for our github repository, then I'll integrate it into my patch?

timmillwood queued 7: fix-fatal.patch for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: fix-fatal.patch, failed testing.