Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Due to changes in head global redirect pretty much fatals on lots of paths.
Comment | File | Size | Author |
---|---|---|---|
#7 | fix-fatal.patch | 5.58 KB | marcingy |
#5 | fix-fatal.patch | 4.84 KB | marcingy |
#3 | fix-fatal.patch | 4.12 KB | marcingy |
id-fatal.patch | 821 bytes | marcingy | |
Comments
Comment #2
marcingy CreditAttribution: marcingy commentedWill look at this tomorrow
Comment #3
marcingy CreditAttribution: marcingy commentedTests are passing locally, there is an item follow up on but core is still heavily using the function currently so happy as a stop gap, basically can't workout how to get Url::fromUri to give me an aliased path at end of day yet from generateFromPath does the trick.
Comment #5
marcingy CreditAttribution: marcingy commentedDoes help if I remember to also add the updated services.yml file
Comment #6
slashrsm CreditAttribution: slashrsm commentedInject?
Comment #7
marcingy CreditAttribution: marcingy commentedComment #8
slashrsm CreditAttribution: slashrsm commentedLooks good to me.
Comment #9
loopduplicateThe patch in #7 works for me too.
Comment #10
loopduplicateComment #11
BerdirNot sure how exactly this overlaps with the changes that we've been working on in our github repository, see #2332377: Chase HEAD.
Comment #12
BerdirOk, that issue is failing on the testbot, want to propose your patch as a pull request for our github repository, then I'll integrate it into my patch?