Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a tiny thing but it makes red squiggly lines appear all over my phpstorm because of the check for valid callback usage.
Comment | File | Size | Author |
---|---|---|---|
commerce_payment_method_callback_comment_fix.patch | 490 bytes | gcb | |
Comments
Comment #2
rszrama CreditAttribution: rszrama commentedfwiw, we don't generally specify variable types for parameters or return values as it wasn't part of the Drupal 7 code comment standards.
Recategorizing this as a task, as it isn't actually a bug in the code. I'm not sure how worth it it is to pursue this, though, as there are dozens of other functions that don't specify a return value type.
Comment #3
gcbYeah, I just wanted it in my site so the error would go away and this is the most sensible way to attach it to the build script. I suppose a better approach would be to fix the comment structure in the entire file and submit that patch... so, one laziness demerit for me!
Comment #4
bojanz CreditAttribution: bojanz commentedAs Ryan said, this doesn't match the D7 coding style.