This is a tiny thing but it makes red squiggly lines appear all over my phpstorm because of the check for valid callback usage.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, commerce_payment_method_callback_comment_fix.patch, failed testing.

rszrama’s picture

Category: Bug report » Task
Status: Needs work » Needs review

fwiw, we don't generally specify variable types for parameters or return values as it wasn't part of the Drupal 7 code comment standards.

Recategorizing this as a task, as it isn't actually a bug in the code. I'm not sure how worth it it is to pursue this, though, as there are dozens of other functions that don't specify a return value type.

gcb’s picture

Yeah, I just wanted it in my site so the error would go away and this is the most sensible way to attach it to the build script. I suppose a better approach would be to fix the comment structure in the entire file and submit that patch... so, one laziness demerit for me!

bojanz’s picture

Status: Needs review » Closed (won't fix)

As Ryan said, this doesn't match the D7 coding style.