What's wrong

On Return form for Customer, "Select All" Checkbox to select all products of order doesn't work.

Solution

Replace $form['#attached']['js'] by $element['#attached']['js'] in commerce_return_field_widget_form() in commerce_return.module.

See next patch.

CommentFileSizeAuthor
#7 commerce_return.line_item_manager.js_0.patch745 bytesyatendrasingh121
#2 commerce_rma-select-all-products-customer-ui-2368113-2.patch2.24 KBGoZ
#1 commerce_rma-select-all-products-customer-ui-2368113-1.patch986 bytesGoZ
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GoZ’s picture

GoZ CreditAttribution: GoZ commented
Status: Active » Needs review
FileSize
commerce_rma-select-all-products-customer-ui-2368113-1.patch986 bytes
GoZ’s picture

GoZ CreditAttribution: GoZ commented
FileSize
commerce_rma-select-all-products-customer-ui-2368113-2.patch2.24 KB

Make select all works checking and unchecking many times.
Also make js a little lighter removing each() function.

GoZ’s picture

GoZ CreditAttribution: GoZ commented
jkuma’s picture

jkuma CreditAttribution: jkuma commented
Status: Needs review » Reviewed & tested by the community

All good !!

jkuma’s picture

jkuma CreditAttribution: jkuma commented
Status: Reviewed & tested by the community » Fixed

Ported to 7.x-2.x branch.

  • goldorak committed a6f0fc8 on 7.x-2.x authored by GoZ 
    Issue #2368113 by GoZ, goldorak: Checkbox select All in customer UI...
yatendrasingh121’s picture

yatendrasingh121 CreditAttribution: yatendrasingh121 commented
FileSize
commerce_return.line_item_manager.js_0.patch745 bytes

This was not working in my case . The problem was drupal standard for writing js file . And after writing js file with drupal standard everthing is working fine .

See attached patch.

jkuma’s picture

jkuma CreditAttribution: jkuma commented

Ok Yatendrashing121, your patch is looking good to me, I'm merging it.

GoZ’s picture

GoZ CreditAttribution: GoZ commented

Seems good to. Thanks Yatendrashing121.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.